-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] sales_team_security: Adaptation to v11 + enhancement #732
Conversation
============================== Security rules for sales teams ============================== This module sets different permissions levels for accessing sales and CRM records based on the sales team: customers, sales orders, leads, opportunities, phone calls and sales teams. It also handles the propagation of the sales team from commercial partners to the contacts, which standard doesn't make. Installation ============ At installation time, this module sets int all the contacts that have the sales team empty the sales team of the parent. If you have a lot of contacts, this operation can take a while. Usage ===== On the user configuration (Configuration > Users > Users), select in the *Sales Team* section the option "See only own team". Then, the documents mentioned before will be filtered out to have only those belonging to the teams the user belongs to. This is complementary to the Sales level access, but sometimes can be incoherent depending on the combination chosen. If you chose "See Own Leads" on _Sales_ section, marking on unmarking the sales team check will be irrelevant, because the most restricting level, which the sales one, will prevail. Known issues/Roadmap ==================== * This module is designed for supporting only sales part, so someone that has access to other Odoo parts (for example, an accountant), shouldn't have this new permission, or some access errors will be found when seeing invoices and other documents. A _sales_team_security_account_ bridge module can be done for fixing this case, but not in the case of for example warehouse.
@ernestotejeda please review |
3b06697
to
b2dbbf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfect on Leads, Pipeline and Quotations. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error when accessing a client's form, even if I access as administrator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the readme it says that the group "User: Own Documents Only" shows those clients who have the user in 'Salesperson'' field, or do not have an assigned Salesperson, however, when I try to reproduce this, also shows clients who have others users in 'Salesperson' field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Leads, Pipeline and Quotations I think it works well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c352c31
to
e1e34fc
Compare
@ernestotejeda thanks for the remarks. I have modified some things according your comments and there are something that should be done in the DB. An alternative solution would be to overwrite some |
db62299
to
2a54b4c
Compare
2a54b4c
to
3e1ed52
Compare
Sales documents permissions by channels (teams)
This module adds a new group called "Channel manager", that includes
the proper permissions for showing only the information related to that
channel:
It also handles the propagation of the sales team from commercial partners to
the contacts, which standard doesn't do.
And finally, partners are restricted to the own ones for the group
"User: Own Documents Only" for being coherent with the permission scheme.
Installation
At installation time, this module sets in all the contacts that have the sales
team empty the sales team of the parent. If you have a lot of contacts, this
operation can take a while.
Configuration
Known issues / Roadmap
doing something similar might conflict with this one.
access to other Odoo parts (for example, an accountant), shouldn't have this
new permission, or some access errors will be found when seeing invoices and
other documents. A
sales_team_security_account
bridge module can be donefor fixing this case, but not in the case of other parts like warehouse.
crm
is independent.