[11.0] [MIG] sale_procurement_group_by_line #673

murtuzasaleh · 2018-07-18T10:08:41Z

Sale Procurement Group by line

This module was written to extend the functionality of procurement groups
created from a Sale order.
On itself, this module does nothing it is a requirement for modules which
needs to create procurement group per sale order line basis.

Migration of module Sale Procurement Group by line v10 to v11.

pedrobaeza · 2018-07-18T10:13:12Z

@jbeficent is this intended for the same as OCA/purchase-workflow#563?

sale_procurement_group_by_line/__manifest__.py

murtuzasaleh · 2018-10-03T06:19:37Z

@pedrobaeza @mreficent Could you please check it.

nikul-serpentcs

Code Review LGTM

nikul-serpentcs

Code Review LGTM

nikul-serpentcs · 2018-10-04T10:03:03Z

@pedrobaeza @JayVora-SerpentCS Could you please review and move forward.

pedrobaeza · 2018-10-11T17:58:24Z

I'm afraid I don't know this module, so others should review it.

HviorForgeFlow · 2018-11-09T09:36:40Z

sale_procurement_group_by_line/README.rst

+needs to create procurement group per sale order line basis.
+
+
+Usage


Improve usage section (add an usage example, where you canbenefit from this module avoid using technical language), add some pictures, would be nice to move readme to new format

sale_procurement_group_by_line/__init__.py

sale_procurement_group_by_line/model/__init__.py

HviorForgeFlow · 2018-11-09T10:16:52Z

sale_automatic_workflow_payment_mode/tests/test_automatic_workflow_payment_mode.py

@@ -52,5 +52,8 @@ def test_full_automatic(self):
        invoice = sale.invoice_ids


That file is not related with this module, please remove

sale_procurement_group_by_line/tests/__init__.py

HviorForgeFlow · 2018-11-09T10:20:14Z

sale_procurement_group_by_line/model/sale.py

+                        line.order_id.partner_shipping_id.
+                        property_stock_customer, line.name, line.order_id.name,
+                        values)
+            except UserError as error:


As an UserError is caught, maybe it's interesting to append which products have raised it.

If super cannot be called then you need to add a comment telling clearly that you are overwriting the original method. Also include it in the known issues section.

JayVora-SerpentCS · 2018-11-13T14:52:30Z

@murtuzasaleh check.

MiquelRForgeFlow

@murtuzasaleh will you finish this PR?

MiquelRForgeFlow · 2018-11-14T11:28:33Z

sale_procurement_group_by_line/model/sale.py

-                subtype_id=self.env.ref('mail.mt_note').id)
-            new_procs += new_proc
-        new_procs.run()
-        super(SaleOrderLine, self)._action_procurement_create()


Why did you delete this super?

@mreficent Because In odoo v11 _action_procurement_create method is removed and added _action_launch_procurement_rule method odoo/odoo@c914df5#diff-bf6a9af0e4d7537746d73deb353f3f8aL210 so I have overwrite this method and added code.

Yeah, but why you remove the super? You can do super with the _action_launch_procurement_rule method.

@mreficent Here super return True , So How can modify the code with super?.

That's way @murtuzasaleh overwrite code and modify that.

Here Super is not need. @aheficent already #673 (comment)

return super(self, SaleOrderLine)._action_launch_procurement_rule()

Hi @murtuzasaleh @nikul-serpentcs Did you try to call super at the end? what does the system do in that case? Are other procurement groups created or the ones you create updated? Maybe they are not. I am not sure looking at the code.

Did you try to call super at the end?

@aheficent Yes, But it's method Call again.

But does that affect the result?

This module extract logic to create multiple procurement group for a single sale order for grouped sale order lines.

* Fix OCA#264 * Fix : Can't create delivery from shipping exception

* [ADD] [9.0] sale_delivery_block * [IMP] Add data with an example Delivery Block Reason. * [FIX] * Able to edit the Delivery Block Reason in state 'sent' * README * [FIX] make sale_delivery_block compatible with sale_procurement_group_by_line * [FIX] travis and data nouptade. * [ADD] delivery block tests. * [IMP] Add the 'Default Delivery Block Reason' in partners. * [IMP] track visibility of delivery block reason * [9.0][IMP] sale_delivery_block: * default_delivery_block is now a comercial field. * When duplicating a sale order the delivery block is recomputed. * [9.0][UPD] sale_delivery_block_proc_group_by_line: Update README. * [FIX] api.model used with api.constrains

AaronHForgeFlow

Code seems ok to me, it is not calling super but conserving the original behavior, plus adding the grouping by key feature.

AaronHForgeFlow · 2018-11-15T10:05:01Z

sale_procurement_group_by_line/model/sale.py

+                        line.order_id.partner_shipping_id.
+                        property_stock_customer, line.name, line.order_id.name,
+                        values)
+            except UserError as error:


If super cannot be called then you need to add a comment telling clearly that you are overwriting the original method. Also include it in the known issues section.

LoisRForgeFlow · 2018-11-22T09:17:01Z

@murtuzasaleh Can you rebase? Error in CI was due to another module, but it's fixed now.

AaronHForgeFlow · 2018-11-22T09:38:38Z

BTW sale_source_by_line will be deprecated. This, this module is only a dependency for this one #668 Do you agree @murtuzasaleh?

MiquelRForgeFlow · 2018-12-12T09:56:57Z

Superseeded by #758.

murtuzasaleh force-pushed the 11.0-mig-sale_procurement_group_by_line branch 3 times, most recently from a41dba2 to 9e145a5 Compare July 18, 2018 11:58

JayVora-SerpentCS suggested changes Jul 24, 2018

View reviewed changes

sale_procurement_group_by_line/__manifest__.py Outdated Show resolved Hide resolved

sale_procurement_group_by_line/__manifest__.py Outdated Show resolved Hide resolved

murtuzasaleh force-pushed the 11.0-mig-sale_procurement_group_by_line branch from 0eb6ede to 0180cbb Compare July 24, 2018 07:35

murtuzasaleh mentioned this pull request Jul 24, 2018

Migration to version 11.0 #538

Closed

65 tasks

murtuzasaleh mentioned this pull request Oct 1, 2018

[11.0][MIG] sale_procurement_group_by_line #689

Closed

nikul-serpentcs reviewed Oct 4, 2018

View reviewed changes

nikul-serpentcs approved these changes Oct 4, 2018

View reviewed changes

pedrobaeza added this to the 11.0 milestone Oct 11, 2018

HviorForgeFlow suggested changes Nov 9, 2018

View reviewed changes

MiquelRForgeFlow reviewed Nov 14, 2018

View reviewed changes

MiquelRForgeFlow mentioned this pull request Nov 14, 2018

[11.0][MIG] sale_stock_picking_blocking_proc_group_by_line #736

Merged

1 task

yvaucher and others added 12 commits November 15, 2018 10:52

Add module sale_procurement_group_by_line

f8c97e4

This module extract logic to create multiple procurement group for a single sale order for grouped sale order lines.

Add OCA module icon

82b4783

Add bug tracker link on README.rst

8c684fc

[UPD] prefix versions with 8.0

db4d407

[MIG] Make modules uninstallable

5f40b32

[MIG] Rename manifest files

978076e

Recreate pickings doesn't show View Delivery Orders button

9410652

* Fix OCA#264 * Fix : Can't create delivery from shipping exception

9.0 sale_procurement_group_by_line

d7b13b2

[MIG] sale_procurement_group_by_line: Migration to 10.0

0b4c1b4

[UPD] Update sale_procurement_group_by_line.pot

fe71c63

[FIX]get picking on sale_procurement_group_by_line

ce83202

AaronHForgeFlow and others added 3 commits November 15, 2018 10:52

[FIX]adapt test to match

6f0bb30

[11.0] [MIG]sale_procurement_group_by_line: Migration to 11.0.

95a2e66

[FIX] Fixed Unit test case

d372e42

murtuzasaleh force-pushed the 11.0-mig-sale_procurement_group_by_line branch from 0180cbb to d372e42 Compare November 15, 2018 06:53

[IMP]sale_procurement_group_by_line: Removed copyright from init files.

c461862

AaronHForgeFlow reviewed Nov 15, 2018

View reviewed changes

MiquelRForgeFlow mentioned this pull request Dec 4, 2018

[11.0][MIG] sale_procurement_group_by_line #758

Merged

pedrobaeza closed this Dec 29, 2018

murtuzasaleh deleted the 11.0-mig-sale_procurement_group_by_line branch May 6, 2019 05:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0] [MIG] sale_procurement_group_by_line #673

[11.0] [MIG] sale_procurement_group_by_line #673

murtuzasaleh commented Jul 18, 2018 •

edited

Loading

pedrobaeza commented Jul 18, 2018

murtuzasaleh commented Oct 3, 2018

nikul-serpentcs left a comment •

edited

Loading

nikul-serpentcs left a comment

nikul-serpentcs commented Oct 4, 2018

pedrobaeza commented Oct 11, 2018

HviorForgeFlow Nov 9, 2018

HviorForgeFlow Nov 9, 2018

HviorForgeFlow Nov 9, 2018

AaronHForgeFlow Nov 15, 2018

JayVora-SerpentCS commented Nov 13, 2018

MiquelRForgeFlow left a comment

MiquelRForgeFlow Nov 14, 2018

murtuzasaleh Nov 15, 2018 •

edited

Loading

MiquelRForgeFlow Nov 15, 2018

nikul-serpentcs Nov 15, 2018

MiquelRForgeFlow Nov 15, 2018

AaronHForgeFlow Nov 15, 2018

nikul-serpentcs Nov 15, 2018

AaronHForgeFlow Nov 15, 2018

AaronHForgeFlow left a comment

AaronHForgeFlow Nov 15, 2018

LoisRForgeFlow commented Nov 22, 2018

AaronHForgeFlow commented Nov 22, 2018

MiquelRForgeFlow commented Dec 12, 2018

		needs to create procurement group per sale order line basis.


		Usage

		@@ -52,5 +52,8 @@ def test_full_automatic(self):
		invoice = sale.invoice_ids

[11.0] [MIG] sale_procurement_group_by_line #673

[11.0] [MIG] sale_procurement_group_by_line #673

Conversation

murtuzasaleh commented Jul 18, 2018 • edited Loading

Sale Procurement Group by line

pedrobaeza commented Jul 18, 2018

murtuzasaleh commented Oct 3, 2018

nikul-serpentcs left a comment • edited Loading

Choose a reason for hiding this comment

nikul-serpentcs left a comment

Choose a reason for hiding this comment

nikul-serpentcs commented Oct 4, 2018

pedrobaeza commented Oct 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayVora-SerpentCS commented Nov 13, 2018

MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

murtuzasaleh Nov 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Nov 22, 2018

AaronHForgeFlow commented Nov 22, 2018

MiquelRForgeFlow commented Dec 12, 2018

murtuzasaleh commented Jul 18, 2018 •

edited

Loading

nikul-serpentcs left a comment •

edited

Loading

murtuzasaleh Nov 15, 2018 •

edited

Loading