Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0] [MIG] sale_validity #666

Merged
merged 12 commits into from
Jan 7, 2019
Merged

[11.0] [MIG] sale_validity #666

merged 12 commits into from
Jan 7, 2019

Conversation

murtuzasaleh
Copy link
Member

Default Quotation Validity

  • With this module, you will be able to configure a default validity delay on quotations.

Migration of module Default Quotation Validity v10 to v11.

@murtuzasaleh murtuzasaleh mentioned this pull request Jul 6, 2018
Closed
65 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jul 6, 2018
@murtuzasaleh murtuzasaleh force-pushed the 11.0-mig-sale_validity branch from 8e86670 to 95c0ed4 Compare July 6, 2018 11:42
nikul-serpentcs
nikul-serpentcs approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM

@pedrobaeza
Copy link
Member

Can you squash a bit commit history avoiding that merge commits?

@murtuzasaleh murtuzasaleh force-pushed the 11.0-mig-sale_validity branch 2 times, most recently from 7d52af1 to 15d7441 Compare October 1, 2018 10:18
@murtuzasaleh
Copy link
Member Author

Can you squash a bit commit history avoiding that merge commits?

@pedrobaeza squashed

JayVora-SerpentCS
JayVora-SerpentCS approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@JayVora-SerpentCS JayVora-SerpentCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

Can you please check conflicts? Why are you modifying that file?

@murtuzasaleh
Copy link
Member Author

Can you please check conflicts? Why are you modifying that file?

@pedrobaeza Done, Here I rebase PR then conflicts error occurs, so I solved it.

@nikul-serpentcs
Copy link
Member

@pedrobaeza @JayVora-SerpentCS Could you please review it and move Forward.

@LoisRForgeFlow
Copy link
Contributor

@murtuzasaleh could you please fix conflicts?

@nikul-serpentcs
Copy link
Member

@lreficent could you please review it?

@LoisRForgeFlow
Copy link
Contributor

@murtuzasaleh that's not the way to solve the conflict (all those "Merge..." commits) you should do a rebase on top of OCA's 11.0 branch.

@murtuzasaleh murtuzasaleh force-pushed the 11.0-mig-sale_validity branch from 0cc59be to c14f523 Compare October 15, 2018 07:55
@murtuzasaleh
Copy link
Member Author

@lreficent Conflicts solved! Could you please review it?

HviorForgeFlow
HviorForgeFlow suggested changes Nov 8, 2018
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to use new readme format

sale_validity/__init__.py Outdated Show resolved Hide resolved
sale_validity/__manifest__.py Outdated Show resolved Hide resolved
sale_validity/models/__init__.py Outdated Show resolved Hide resolved
sale_validity/models/company.py Outdated Show resolved Hide resolved
sale_validity/models/res_config_settings.py Outdated Show resolved Hide resolved
sale_validity/models/sale_config_settings.py Outdated Show resolved Hide resolved
sale_validity/models/sale_order.py Outdated Show resolved Hide resolved
sale_validity/tests/__init__.py Outdated Show resolved Hide resolved
sale_validity/tests/test_sale_validity.py Outdated Show resolved Hide resolved
sale_validity/views/sale_config_settings.xml Outdated Show resolved Hide resolved
@JayVora-SerpentCS
Copy link
Contributor

@murtuzasaleh ping

@murtuzasaleh murtuzasaleh force-pushed the 11.0-mig-sale_validity branch 2 times, most recently from c14f523 to 63d53be Compare November 14, 2018 05:41
LoisRForgeFlow
LoisRForgeFlow approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok 👍

@LoisRForgeFlow
Copy link
Contributor

@hveficent could you update your review?

HviorForgeFlow
HviorForgeFlow approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza
pedrobaeza requested changes Nov 16, 2018
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odoo core already contains an expiration date:

seleccion_012

so you should reuse that field instead of creating a new one. And thus the module should be renamed to other thing like sale_order_default_expiration

pedrobaeza
pedrobaeza approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked incorrectly to this and it's not creating a new field. I merge.

jbaudoux and others added 12 commits January 7, 2019 09:29
@jbaudoux @pedrobaeza
[ADD] module sale_validity : Add validity date on Sales Quotation
ca009a1 
(../trunk-generic/ rev 1)
@nbessi @pedrobaeza
[FIX] sale_validity: import style + licence + manifest description + …
86ff4e5 
…PEP8
@pedrobaeza
Update v7 code style and PEP8
3fee768 
Add POT file
Add default value duration (in days) for validity per company (ignored if you leave the value to 0, which is the default).
@pedrobaeza
Launchpad automatic translations update.
e8c81ba
@eLBati @pedrobaeza
[FIX] repository PEP8
54ed495
@pedrobaeza
- Set as uninstallable and moved to __unported__ dir all modules.
962dc18 
- Update travis.yml to 8.0
@yvaucher @pedrobaeza
[MIG] sale_validity: Migration to 8.0
c706b13 
* New API
* add tests
@gurneyalex @pedrobaeza
fix sale_validity test
f29fa3f
@sysadminmatmoz @pedrobaeza
Slovene translations added
cd0b9c1
@alexis-via @pedrobaeza
[MIG] sale_validity to v10.0
39e0f2a 
Convert YAML tests to unittests
Add README.rst
@oca-travis @pedrobaeza
[UPD] Update sale_validity.pot
f9fe2b7
@murtuzasaleh @pedrobaeza
[MIG]Migrated Code
70990f7
@pedrobaeza pedrobaeza force-pushed the 11.0-mig-sale_validity branch from f4d57a7 to 70990f7 Compare January 7, 2019 08:35
@oca-clabot
Copy link

Hey @murtuzasaleh, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

  • Launchpad Translations on behalf of sale-core-editors (no github login found)

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza merged commit 8ca2cdc into OCA:11.0 Jan 7, 2019
@murtuzasaleh murtuzasaleh deleted the 11.0-mig-sale_validity branch May 6, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@JayVora-SerpentCS JayVora-SerpentCS JayVora-SerpentCS approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.