11.0 mig sale force invoiced #649
Conversation
* [ADD] module 'sale_force_invoiced' for 9.0 * [FIX] Travis
andreasdsp
force-pushed
the
11.0-mig-sale_force_invoiced
branch
from
41e2103 to
3175128
Compare
sale_force_invoiced/README.rst
Outdated
|
|
||
| .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
| :alt: Try me on Runbot | ||
| :target: https://runbot.odoo-community.org/runbot/167/10.0 |
There was a problem hiding this comment.
Links to old runbot, update to 11.0
sale_force_invoiced/__init__.py
Outdated
| @@ -0,0 +1,5 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Remove al coding: utf-8 lines, no longer needed with python 3?
andreasdsp
force-pushed
the
11.0-mig-sale_force_invoiced
branch
from
cfae3f5 to
5249bb4
Compare
|
Thank you for the review. i had remove utf-8 code and change runbot url. |
|
ready to merge |
|
@pedrobaeza I think this can be merged |
| @@ -1,4 +1,3 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
I think this change should be reverted
There was a problem hiding this comment.
@mreficent This header is no longer required, assumed is UTF-8.
See odoo documentation, there is the header is missing:
https://www.odoo.com/documentation/11.0/reference/data.html
In the newer xml files in default Odoo you can also see that this line is absent.
There was a problem hiding this comment.
But your example is not valid. In https://www.odoo.com/documentation/10.0/reference/data.html the header is also missing.
There was a problem hiding this comment.
For being a correct xml with UTF-8 coded words, you should include that attribute and the header. If not, there can be problems depending on the lxml library implementation and version. What is not needed in python 3 is for python files.
There was a problem hiding this comment.
@mreficent I did not say it was new with Odoo 11..
In that case Odoo is also doing things wrong, for example in this file: https://github.com/odoo/odoo/blob/11.0/addons/hr_recruitment/views/hr_department_views.xml
(For extra confusion, odoo guidelines specify the utf-8 header for python files, but not for the xml files.. :) )
|
Question : When the SO is done, the field becomes editable ! But when the SO is done, in invoice and delivery both are said done, isnt it ? |
|
@pedrobaeza I think this PR should be closed because this module is merged in #688 |
No description provided.