[11.0][MIG] sale_triple_discount #627

xavierjimenez · 2018-04-05T07:58:35Z

Migration of sale_triple_discount module to version 11.0

Depends on:

[11.0][MIG] account_invoice_triple_discount account-invoicing#370 account_invoicing_triple_discount

pedrobaeza · 2018-04-05T08:03:36Z

You have added a .DS_store file

misern2

You should update the security groups on the account_invoice views for the new fields.

Check core code for the discount field:

https://github.com/odoo/odoo/blob/00ef138ce038d4f8e5a9b7ad2f23ab483e282ebb/addons/sale/views/sale_views.xml#L718-L738

rafaelbn · 2018-04-13T22:21:27Z

Thanks @xavierjimenez ! Please rebase as OCA/account-invoicing#370 has been merge and then we could test this one! 😄

pedrobaeza · 2018-04-13T22:24:09Z

No need to rebase, as it's in another repository. Just to restart CIs.

xavierjimenez · 2018-04-18T13:35:33Z

I'm not sure how to do that, do I have to open a new PR?

pedrobaeza · 2018-04-18T15:52:31Z

I have restarted both.

rafaelbn · 2018-04-26T22:53:08Z

There are missing dependencies

2018-04-18 16:06:05,315 5431 WARNING openerp_test odoo.modules.loading: Transient module states were reset
2018-04-18 16:06:05,315 5431 ERROR openerp_test odoo.modules.registry: Failed to load registry
Traceback (most recent call last):
File "/home/travis/OCB-11.0/odoo/modules/registry.py", line 85, in new
odoo.modules.load_modules(registry._db, force_demo, status, update_module)
File "/home/travis/OCB-11.0/odoo/modules/loading.py", line 308, in load_modules
modules.button_install()
File "<decorator-gen-39>", line 2, in button_install
File "/home/travis/OCB-11.0/odoo/addons/base/module/module.py", line 71, in check_and_log
return method(self, *args, **kwargs)
File "/home/travis/OCB-11.0/odoo/addons/base/module/module.py", line 397, in button_install
modules._state_update('to install', ['uninstalled'])
File "/home/travis/OCB-11.0/odoo/addons/base/module/module.py", line 362, in _state_update
raise UserError(_("You try to install module '%s' that depends on module '%s'.\nBut the latter module is not available in your system.") % (module.name, dep.name,))
odoo.exceptions.UserError: ("You try to install module 'sale_triple_discount' that depends on module 'account_invoice_triple_discount'.\nBut the latter module is not available in your system.", '')
2018-04-18 16:06:05,316 5431 CRITICAL openerp_test odoo.service.server: Failed to initialize database `openerp_test`.
Traceback (most recent call last):
File "/home/travis/OCB-11.0/odoo/service/server.py", line 925, in preload_registries
registry = Registry.new(dbname, update_module=update_module)
File "/home/travis/OCB-11.0/odoo/modules/registry.py", line 85, in new
odoo.modules.load_modules(registry._db, force_demo, status, update_module)
File "/home/travis/OCB-11.0/odoo/modules/loading.py", line 308, in load_modules
modules.button_install()
File "<decorator-gen-39>", line 2, in button_install
File "/home/travis/OCB-11.0/odoo/addons/base/module/module.py", line 71, in check_and_log
return method(self, *args, **kwargs)
File "/home/travis/OCB-11.0/odoo/addons/base/module/module.py", line 397, in button_install
modules._state_update('to install', ['uninstalled'])
File "/home/travis/OCB-11.0/odoo/addons/base/module/module.py", line 362, in _state_update
raise UserError(_("You try to install module '%s' that depends on module '%s'.\nBut the latter module is not available in your system.") % (module.name, dep.name,))
odoo.exceptions.UserError: ("You try to install module 'sale_triple_discount' that depends on module 'account_invoice_triple_discount'.\nBut the latter module is not available in your system.", '')

murtuzasaleh · 2018-07-06T11:14:05Z

@xavierjimenez I am starting working on it.
cc @pedrobaeza

xavierjimenez · 2018-07-06T13:51:08Z

@murtuzasaleh I think the module is working fine, there's a dependency issue with another module (account_invoice_triple_discount) but that module is already merged so I'm not sure how I can solve that.

pedrobaeza · 2018-07-06T13:52:23Z

Is the repository put in oca_dependencies.txt in root folder?

pedrobaeza · 2018-07-06T14:47:40Z

@xavierjimenez can you check what I have said?

xavierjimenez · 2018-07-06T14:53:50Z

I just checked it out and it's not, can I add it?

pedrobaeza · 2018-07-06T14:55:30Z

Yes, of course. That's the idea when you add a new module (migrated or totally new) that depends on modules on other repositories. Doing so, you will get the module available and Travis/runbot will be OK.

pedrobaeza · 2018-07-06T15:33:17Z

All green! @murtuzasaleh @JayVora-SerpentCS can you please review this one now that the problem has gone?

JayVora-SerpentCS · 2018-07-07T09:06:07Z

sale_triple_discount/README.rst

+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/167/10.0


JayVora-SerpentCS · 2018-07-07T09:07:14Z

sale_triple_discount/__manifest__.py

+              'ADHOC SA, '
+              'Agile Business Group, '
+              'Tecnativa, '
+              'Odoo Community Association (OCA)',


Authorname should be added when you added a feature my friend. If not, add your name to contributors in readme.

JayVora-SerpentCS · 2018-07-07T09:07:25Z

sale_triple_discount/__manifest__.py

+              'Agile Business Group, '
+              'Tecnativa, '
+              'Odoo Community Association (OCA)',
+    'website': 'https://odoo-community.org',


website -> https://github.com/OCA/sale-workflow

murtuzasaleh · 2018-07-09T05:28:41Z

sale_triple_discount/__manifest__.py

+    'license': 'AGPL-3',
+    'summary': 'Manage triple discount on sale order lines',
+    'depends': [
+        'sale',


IMO it should be sale_management instead of a sale module.

xavierjimenez · 2018-07-09T06:45:18Z

Changes done! I'll make the squash with the previous commits when it's ready to merge.

rafaelbn · 2018-08-01T18:39:08Z

Hi @murtuzasaleh @JayVora-SerpentCS @misern2 this PR is all green and attended comment.

@xavierjimenez just take a look in:

[FIX] [10.0][FIX] sale_triple_discount: case taxes globally rounded #544 (this could happens also in v11)
[IMP] [IMP] 10.0 sale_triple_discount: rework discount computation #671

Thanks a lot for your 🍏 work! 👍

cc @chienandalu

rafaelbn · 2018-08-01T18:57:42Z

Hi @xavierjimenez I've tested it and my doubt is about report. Does it have any sense for you?

Take a look:

rafaelbn

I'm not blocking but IMHO report (PDF of SO) must be improved

xavierjimenez · 2018-08-02T07:52:54Z

Hi @rafaelbn, thanks for the review!

I agree, the report needs a change so I'll try to add the others discounts on the report if they are set.

pedrobaeza · 2018-08-03T07:16:20Z

@xavierjimenez I have just discovered the field price_reduce: https://github.com/odoo/odoo/blob/11.0/addons/sale/models/sale.py#L783, that contains the price with the discount. I'm not sure if this field is used everywhere, but maybe changing the computing of it can be enough.

Can you please try?

rafaelbn · 2019-03-14T04:43:19Z

Hello @xavierjimenez @misern2 !

Are you using this module in production enviroment?

Take care for fixes in v10 that apply in this PR

We could try to push this PR reviewing fixes of v10, rebasing this PR and checking again.

Thanks

rousseldenis · 2021-12-23T16:16:49Z

Closing this as very old and no answer from author. Please feel free to reopen it if needed.

tafaRU and others added 4 commits April 5, 2018 09:54

[ADD] sale_triple_discount

9b52b37

[MIG] sale_triple_discount: Migration to 10.0

657247d

OCA Transbot updated translations from Transifex

46314c6

[11.0][MIG] sale_triple_discount

19cb943

xavierjimenez changed the title ~~11.0 mig sale_triple_discount~~ [11.0][MIG] sale_triple_discount Apr 5, 2018

pedrobaeza added this to the 11.0 milestone Apr 5, 2018

[FIX] Remove DS_Store

93d133c

misern2 suggested changes Apr 6, 2018

View reviewed changes

rafaelbn added the needs review label Apr 13, 2018

rafaelbn added work in progress and removed needs review labels Apr 26, 2018

pedrobaeza mentioned this pull request Jul 6, 2018

[11.0] [MIG] sale_triple_discount #667

Closed

[FIX] Add account-invoicing dependency

b1b2a00

JayVora-SerpentCS suggested changes Jul 7, 2018

View reviewed changes

murtuzasaleh reviewed Jul 9, 2018

View reviewed changes

[FIX] Changes after reviews

ebe2e00

rafaelbn added needs review and removed work in progress labels Aug 1, 2018

rafaelbn reviewed Aug 1, 2018

View reviewed changes

rafaelbn mentioned this pull request Aug 9, 2018

[11.0][NEW] sale_general_discount #676

Closed

emagdalenaC2i mentioned this pull request Dec 29, 2018

Migration to version 11.0 #538

Closed

65 tasks

rousseldenis closed this Dec 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] sale_triple_discount #627

[11.0][MIG] sale_triple_discount #627

xavierjimenez commented Apr 5, 2018 •

edited by rafaelbn

Loading

pedrobaeza commented Apr 5, 2018

misern2 left a comment

rafaelbn commented Apr 13, 2018

pedrobaeza commented Apr 13, 2018

xavierjimenez commented Apr 18, 2018

pedrobaeza commented Apr 18, 2018

rafaelbn commented Apr 26, 2018

murtuzasaleh commented Jul 6, 2018

xavierjimenez commented Jul 6, 2018

pedrobaeza commented Jul 6, 2018

pedrobaeza commented Jul 6, 2018

xavierjimenez commented Jul 6, 2018

pedrobaeza commented Jul 6, 2018

pedrobaeza commented Jul 6, 2018

JayVora-SerpentCS Jul 7, 2018

JayVora-SerpentCS Jul 7, 2018

JayVora-SerpentCS Jul 7, 2018

murtuzasaleh Jul 9, 2018 •

edited

Loading

xavierjimenez commented Jul 9, 2018

rafaelbn commented Aug 1, 2018

rafaelbn commented Aug 1, 2018

rafaelbn left a comment

xavierjimenez commented Aug 2, 2018

pedrobaeza commented Aug 3, 2018

rafaelbn commented Mar 14, 2019

rousseldenis commented Dec 23, 2021

[11.0][MIG] sale_triple_discount #627

[11.0][MIG] sale_triple_discount #627

Conversation

xavierjimenez commented Apr 5, 2018 • edited by rafaelbn Loading

pedrobaeza commented Apr 5, 2018

misern2 left a comment

Choose a reason for hiding this comment

rafaelbn commented Apr 13, 2018

pedrobaeza commented Apr 13, 2018

xavierjimenez commented Apr 18, 2018

pedrobaeza commented Apr 18, 2018

rafaelbn commented Apr 26, 2018

murtuzasaleh commented Jul 6, 2018

xavierjimenez commented Jul 6, 2018

pedrobaeza commented Jul 6, 2018

pedrobaeza commented Jul 6, 2018

xavierjimenez commented Jul 6, 2018

pedrobaeza commented Jul 6, 2018

pedrobaeza commented Jul 6, 2018

JayVora-SerpentCS Jul 7, 2018

Choose a reason for hiding this comment

JayVora-SerpentCS Jul 7, 2018

Choose a reason for hiding this comment

JayVora-SerpentCS Jul 7, 2018

Choose a reason for hiding this comment

murtuzasaleh Jul 9, 2018 • edited Loading

Choose a reason for hiding this comment

xavierjimenez commented Jul 9, 2018

rafaelbn commented Aug 1, 2018

rafaelbn commented Aug 1, 2018

rafaelbn left a comment

Choose a reason for hiding this comment

xavierjimenez commented Aug 2, 2018

pedrobaeza commented Aug 3, 2018

rafaelbn commented Mar 14, 2019

rousseldenis commented Dec 23, 2021

xavierjimenez commented Apr 5, 2018 •

edited by rafaelbn

Loading

murtuzasaleh Jul 9, 2018 •

edited

Loading