11.0 mig sale order line date #600
Conversation
sale_order_line_date/__manifest__.py
Outdated
| @@ -1,4 +1,3 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
@OpenCode why removing everywhere the coding line?
There was a problem hiding this comment.
| class SaleOrderLine(models.Model): | ||
| _inherit = 'sale.order.line' | ||
|
|
||
| requested_date = fields.Datetime() |
There was a problem hiding this comment.
Good to add string to it
There was a problem hiding this comment.
"requested_date" is converted automatically in "Requested Date" by Odoo. Why add a string?
There was a problem hiding this comment.
True that, I realised later.
| if res.order_id.requested_date and not res.requested_date: | ||
| res.write({'requested_date': res.order_id.requested_date}) | ||
| return res | ||
|
|
There was a problem hiding this comment.
Rather than overriding create() and write(), cannot we make an onchange / depends(order_id.requested_date), and do the rest?
| return res | ||
|
|
||
| @api.multi | ||
| def _prepare_order_line_procurement(self, group_id=False): |
There was a problem hiding this comment.
This method's name is different in v11. change to:
def _prepare_procurement_values(self, group_id=False):
|
|
||
| @api.multi | ||
| def _prepare_order_line_procurement(self, group_id=False): | ||
| self.ensure_one() |
There was a problem hiding this comment.
This is not needed as it already present on the parent method.
| def _prepare_order_line_procurement(self, group_id=False): | ||
| self.ensure_one() | ||
| vals = super(SaleOrderLine, self).\ | ||
| _prepare_order_line_procurement(group_id) |
There was a problem hiding this comment.
change accordingly to above comment
|
@OpenCode I really needed this fixed so I've just proposed you a PR. |
|
@lreficent Done |
No description provided.