-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] sale_merge_draft_invoice #569
[11.0][MIG] sale_merge_draft_invoice #569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor doc comment, rest LGTM.
sale_merge_draft_invoice/README.rst
Outdated
|
||
The merge between invoices is done when the partner and the currency are the | ||
same. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section should reference #568 capabilities and Odoo default capabilities. The way it reads now, it reads like this module groups by partner and currency, when in fact it doesn't, it just considers draft invoices in the grouping.
Explain the default group of Odoo like you have, then explain that alternative custom groupings can be achieved using that module.
Something like.
Odoo can merge sales orders into a single invoice, grouped by partner and currency, when the sales orders are selected and invoiced together. This module extends the grouping to also consider any pre-existing draft invoices and merge them.
If you also need to group on fields other than partner and currency, the OCA module sale_invoice_group_method allows you to specify alternative grouping methods and is fully compatible with this module.
8dd8717
to
40f1c71
Compare
@gdgellatly - I really like the way you explain it! Already changed! Thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
150c6be
to
1bbb1ba
Compare
No major changes
Dependencies: