Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] sale_merge_draft_invoice #569

Merged
merged 2 commits into from
Dec 19, 2017

Conversation

rgarnau
Copy link

@rgarnau rgarnau commented Nov 14, 2017

@pedrobaeza pedrobaeza added this to the 11.0 milestone Nov 14, 2017
Copy link
Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@gdgellatly gdgellatly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc comment, rest LGTM.


The merge between invoices is done when the partner and the currency are the
same.

Copy link
Contributor

@gdgellatly gdgellatly Dec 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section should reference #568 capabilities and Odoo default capabilities. The way it reads now, it reads like this module groups by partner and currency, when in fact it doesn't, it just considers draft invoices in the grouping.

Explain the default group of Odoo like you have, then explain that alternative custom groupings can be achieved using that module.

Something like.

Odoo can merge sales orders into a single invoice, grouped by partner and currency, when the sales orders are selected and invoiced together. This module extends the grouping to also consider any pre-existing draft invoices and merge them.

If you also need to group on fields other than partner and currency, the OCA module sale_invoice_group_method allows you to specify alternative grouping methods and is fully compatible with this module.

@rgarnau rgarnau force-pushed the 11.0-mig-sale_merge_draft_invoice branch from 8dd8717 to 40f1c71 Compare December 13, 2017 13:27
@rgarnau
Copy link
Author

rgarnau commented Dec 13, 2017

@gdgellatly - I really like the way you explain it! Already changed! Thank you!!

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rgarnau rgarnau force-pushed the 11.0-mig-sale_merge_draft_invoice branch from 150c6be to 1bbb1ba Compare December 19, 2017 09:06
@JordiBForgeFlow JordiBForgeFlow merged commit 902eafb into OCA:11.0 Dec 19, 2017
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 29, 2018
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants