-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] Migrated sale_cancel_reason module in v11. #559
[ADD] Migrated sale_cancel_reason module in v11. #559
Conversation
I'm interested in the migration of this module. I see you have it almost done but it's stopped 7 months ago. Thanks and best regards. |
@js-landoo Please proceed to make your PR. |
OK @JayVora-SerpentCS we will proceed. Thanks. |
I assume the history is not preserved, so we must close this PR. @pedrobaeza . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve Code
@@ -0,0 +1,5 @@ | |||
# -*- coding: utf-8 -*- | |||
# Copyright 2013 Guewen Baconnier, Camptocamp SA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Copyright From all __init__.py
file.
'author': "Camptocamp,Odoo Community Association (OCA)", | ||
'category': 'Sale', | ||
'license': 'AGPL-3', | ||
'website': "http://www.camptocamp.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace URL as per this
'sale', | ||
], | ||
'data': [ | ||
'wizard/cancel_reason_view.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix sequence also
If Create new PR then adding all comments & preserv history |
Closing as indicated by @JayVora-SerpentCS in #559 (comment) |
Migrated sale_cancel_reason module in v11.