Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Migrated sale_cancel_reason module in v11. #559

Closed

Conversation

sudhir-serpentcs
Copy link

Migrated sale_cancel_reason module in v11.

@js-landoo
Copy link

Hi @sudhir-serpentcs

I'm interested in the migration of this module. I see you have it almost done but it's stopped 7 months ago.
Are you planning to finish it?
Can I help you in any way?

Thanks and best regards.

@JayVora-SerpentCS
Copy link
Contributor

@js-landoo Please proceed to make your PR.

@js-landoo
Copy link

OK @JayVora-SerpentCS we will proceed. Thanks.

@JayVora-SerpentCS
Copy link
Contributor

I assume the history is not preserved, so we must close this PR. @pedrobaeza .
@Swapnesh-SerpentCS can make new one.

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
# Copyright 2013 Guewen Baconnier, Camptocamp SA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Copyright From all __init__.py file.

'author': "Camptocamp,Odoo Community Association (OCA)",
'category': 'Sale',
'license': 'AGPL-3',
'website': "http://www.camptocamp.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace URL as per this

'sale',
],
'data': [
'wizard/cancel_reason_view.xml',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix sequence also

@nikul-serpentcs
Copy link
Member

If Create new PR then adding all comments & preserv history

@rafaelbn
Copy link
Member

Closing as indicated by @JayVora-SerpentCS in #559 (comment)

@rafaelbn rafaelbn closed this Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants