[11.0][MIG] partner_prospect: Migration to 11.0 #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oihane
force-pushed
the
11.0-mig-partner_prospect
branch
from
8ed2091 to
7bfb5b8
Compare
oihane
force-pushed
the
11.0-mig-partner_prospect
branch
from
7bfb5b8 to
eda7a33
Compare
oihane
force-pushed
the
11.0-mig-partner_prospect
branch
from
eda7a33 to
0cc44a6
Compare
Closed
pedrobaeza
approved these changes
Jun 16, 2018
|
👍 |
MiquelRForgeFlow
suggested changes
Jul 11, 2018
There was a problem hiding this comment.
Hi @oihane
That's an old module you migrated, good! 👍
But let me tell you that there is some OCA coding guidelines that this module doesn't meet:
- Readme file at least should have to meet the template https://raw.githubusercontent.com/OCA/maintainer-tools/52f41366ab39ea90e66f3e3a2b5cd7691b4219df/template/module/README.rst
- manifest file as https://github.com/OCA/maintainer-tools/blob/master/template/module/__manifest__.py
- check the correct format of copyrights headers
- coding utf-8 in python files should be removed in v11
- also tags in xml files should be removed
It would be nice if all of these could be cleaned.
Best regards
|
Hello @mreficent |
oihane
force-pushed
the
11.0-mig-partner_prospect
branch
from
85f0b3c to
4fe7077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please sb mark it as WIP