Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0] [MIG] Migrating "sale_mrp_link" to 11.0 #1031

Merged
merged 7 commits into from
Mar 10, 2020
Merged

[11.0] [MIG] Migrating "sale_mrp_link" to 11.0 #1031

merged 7 commits into from
Mar 10, 2020

Conversation

NachoAlesLopez
Copy link

@NachoAlesLopez NachoAlesLopez mentioned this pull request Dec 31, 2019
Closed
65 tasks
mariaasunciondaza
mariaasunciondaza approved these changes Jan 3, 2020
View reviewed changes
Copy link

@mariaasunciondaza mariaasunciondaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review Ok

@rousseldenis rousseldenis added this to the 11.0 milestone Jan 3, 2020
rousseldenis
rousseldenis reviewed Jan 3, 2020
View reviewed changes
sale_mrp_link/__manifest__.py Outdated
'summary': 'Show manufacturing orders generated from sales order',
'version': '11.0.1.0.0',
'development_status': 'Production/Stable',
'category': 'Sales Management',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this by 'Sales'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

rousseldenis
rousseldenis approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Minor comment

nikul-serpentcs
nikul-serpentcs approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@NachoAlesLopez NachoAlesLopez force-pushed the 11.0-mig-sale_mrp_link branch from effd915 to 94be229 Compare January 7, 2020 08:31
@dreispt
Copy link
Member

dreispt commented Mar 10, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-1031-by-dreispt-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 57bbf58 into OCA:11.0 Mar 10, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b200386. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariaasunciondaza mariaasunciondaza mariaasunciondaza approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
9 participants
@NachoAlesLopez @OCA-git-bot @dreispt @nikul-serpentcs @rousseldenis @mariaasunciondaza @achaussende @oca-travis @tafaRU