[16.0] [FIX] fastapi: Unflag save_session in routing info

[paradoxxxzero]

This is as much a PR as a question.

Is there any reason to not set the save_session to False and thus remove the session_id cookie?

FYI: @sebastienbeau

[OCA-git-bot]

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

[lmignon]

This is as much a PR as a question.

Is there any reason to not set the save_session to False and thus remove the session_id cookie?

by ignorance ...

[lmignon]

it makes sense

[sbidoul]

Does this have backward compatibility implications?

[paradoxxxzero]

Not that I know of, the session should not be used in the api.

[flotho]

Make sense,
LGTM

[lmignon]

We could make it configurable on the endpoint.

[sbidoul]

I think there are people who use regular Odoo users to authenticate REST APIs. There were PR to that end for base_rest in the past, IIRC. So if this influences such use cases (I'm not sure myself), it's probably necessary to make it configurable.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[sebastienbeau]

@sbidoul @lmignon I think we can start by just add this default value. Then in your custom you can still inherit the method "_get_routing_info" to change the value and also to change the "auth" params to use native odoo authentification

[lmignon]

@sbidoul @lmignon I think we can start by just add this default value. Then in your custom you can still inherit the method "_get_routing_info" to change the value and also to change the "auth" params to use native odoo authentification

akretion#7 😏

[paradoxxxzero]

Merged (and linted :p)

[lmignon]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-442-by-lmignon-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at dae198b. Thanks a lot for contributing to OCA. ❤️