-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16][FIX] fastapi: Compatibility with latest Odoo #416
Conversation
9e92d87
to
e9ffc00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changes and the issue with the Odoo module has been resolved on Odoo.sh for version 16.0 latest. The solution implemented in this pull request effectively addresses the problem I encountered. Great work, and thank you for the quick turnaround!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code review + tests (with old + newest version of Odoo to test both compatibility)
Thanks for the fast fix Laurent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I suppose it might merged as quick fix ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From odoo/odoo@cb1d057, the orignal werkzeug request is wrapped in a dedicated class to keep under control the attributes developers use. This change add code to make the fastapi addon working with version including this last change and prior version refs OCA#414
e9ffc00
to
8c95a74
Compare
@florian-dacosta Can you test-it again on latest odoo? runbaoat seems to have some trouble. On old version it works (tested on my project). |
I have just re-tested the latest version of this PR with the latest version of Odoo on my project and it works fine. |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
Thank you to all for the tests and reviews. |
Congratulations, your PR was merged at 4d79ee0. Thanks a lot for contributing to OCA. ❤️ |
From odoo/odoo@cb1d057, the orignal werkzeug request is wrapped in a dedicated class to keep under control the attributes developers use. This change add code to make the fastapi addon working with version including this last change and prior version
fixes #414