Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16][FIX] fastapi: Compatibility with latest Odoo #416

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Feb 20, 2024

From odoo/odoo@cb1d057, the orignal werkzeug request is wrapped in a dedicated class to keep under control the attributes developers use. This change add code to make the fastapi addon working with version including this last change and prior version

fixes #414

@lmignon lmignon marked this pull request as ready for review February 20, 2024 09:43
Copy link

@Tscunami Tscunami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes and the issue with the Odoo module has been resolved on Odoo.sh for version 16.0 latest. The solution implemented in this pull request effectively addresses the problem I encountered. Great work, and thank you for the quick turnaround!

Copy link

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review + tests (with old + newest version of Odoo to test both compatibility)
Thanks for the fast fix Laurent

Copy link
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bealdav
Copy link
Member

bealdav commented Feb 20, 2024

I suppose it might merged as quick fix ?

Copy link

@JanQubiQ JanQubiQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

From odoo/odoo@cb1d057, the orignal werkzeug request is wrapped in a dedicated class to keep under control the attributes developers use. This change add code to make the fastapi addon working with version including this last change and prior version

refs OCA#414
@lmignon
Copy link
Contributor Author

lmignon commented Feb 20, 2024

@florian-dacosta Can you test-it again on latest odoo? runbaoat seems to have some trouble. On old version it works (tested on my project).

@florian-dacosta
Copy link

florian-dacosta commented Feb 20, 2024

I have just re-tested the latest version of this PR with the latest version of Odoo on my project and it works fine.

@lmignon
Copy link
Contributor Author

lmignon commented Feb 20, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-416-by-lmignon-bump-patch, awaiting test results.

@lmignon
Copy link
Contributor Author

lmignon commented Feb 20, 2024

Thank you to all for the tests and reviews.

@OCA-git-bot OCA-git-bot merged commit f0cfff3 into OCA:16.0 Feb 20, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4d79ee0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[16.0] fastapi error on request
6 participants