Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] graphql_base #397

Closed
wants to merge 3 commits into from

Conversation

dduarte-odoogap
Copy link

No description provided.

@dduarte-odoogap dduarte-odoogap mentioned this pull request Nov 27, 2023
18 tasks
@sbidoul
Copy link
Member

sbidoul commented Dec 6, 2023

/ocabot migration graphql_base

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 6, 2023
@sbidoul sbidoul changed the base branch from 16.0 to 17.0 December 6, 2023 09:24
@sbidoul
Copy link
Member

sbidoul commented Dec 6, 2023

/ocabot migration graphql_base

@OCA-git-bot OCA-git-bot modified the milestones: 16.0, 17.0 Dec 6, 2023
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 14, 2024
@github-actions github-actions bot closed this Aug 18, 2024
@sbidoul sbidoul reopened this Aug 18, 2024
@sbidoul
Copy link
Member

sbidoul commented Aug 18, 2024

Can you preserve the commit history using the recommended procedure? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

@dduarte-odoogap
Copy link
Author

@sbidoul sorry might have missed something, will check

Currently translated at 100.0% (1 of 1 strings)

Translation: rest-framework-16.0/rest-framework-16.0-graphql_base
Translate-URL: https://translation.odoo-community.org/projects/rest-framework-16-0/rest-framework-16-0-graphql_base/it/
@dduarte-odoogap
Copy link
Author

@sbidoul please check

@sbidoul
Copy link
Member

sbidoul commented Aug 19, 2024

Ah, no, my bad, it was good already, since the branch was initialized from 16.0.

@sbidoul
Copy link
Member

sbidoul commented Aug 20, 2024

Please set installable=True in both manifests.

@dduarte-odoogap
Copy link
Author

@sbidoul it's done

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look if something could be improved, but the change looks good, and the demo works, so 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dduarte-odoogap
Copy link
Author

I did not look if something could be improved, but the change looks good, and the demo works, so 👍

@sbidoul we use this module a lot, will check if we can propose some improvements latter on.

@sbidoul
Copy link
Member

sbidoul commented Aug 21, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-397-by-sbidoul-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 21, 2024
Signed-off-by sbidoul
@OCA-git-bot
Copy link
Contributor

@sbidoul The merge process could not be finalized, because command /tmp/tmpwrzcqwqe/bin/python -m build --wheel --outdir /tmp/tmpwnmrfyvo --no-isolation /tmp/tmpfo4tc12v/graphql_base failed with output:

* Getting build dependencies for wheel...
* Building wheel...
Could not import runpy module
Traceback (most recent call last):
  File "<frozen runpy>", line 15, in <module>
  File "<frozen importlib.util>", line 16, in <module>
  File "/usr/lib/python3.12/threading.py", line 6, in <module>
    import functools
  File "/usr/lib/python3.12/functools.py", line 22, in <module>
    from types import GenericAlias
  File "/tmp/tmpfo4tc12v/graphql_base/types.py", line 4, in <module>
    import graphene
ModuleNotFoundError: No module named 'graphene'
Traceback (most recent call last):
  File "/tmp/tmpwrzcqwqe/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in <module>
    main()
  File "/tmp/tmpwrzcqwqe/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 357, in main
    json_out["return_val"] = hook(**hook_input["kwargs"])
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpwrzcqwqe/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 271, in build_wheel
    return _build_backend().build_wheel(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpwrzcqwqe/lib/python3.12/site-packages/whool/buildapi.py", line 194, in build_wheel
    return _build_wheel(Path.cwd(), Path(wheel_directory), editable=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpwrzcqwqe/lib/python3.12/site-packages/whool/buildapi.py", line 174, in _build_wheel
    subprocess.run(
  File "/usr/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/tmp/tmpwrzcqwqe/bin/python', '-m', 'wheel', 'pack', '-d', '/tmp/tmpwnmrfyvo', '/tmp/tmpzp4063is']' returned non-zero exit status 1.

ERROR Backend subprocess exited when trying to invoke build_wheel

@sbidoul
Copy link
Member

sbidoul commented Aug 21, 2024

Hm, that's the bot build process being confused by this types.py at the addon root. I'll need to fix it in the bot.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 25, 2024
@dreispt dreispt changed the title 17.0 mig graphql base 17.0 mig graphql_base Aug 29, 2024
@yvaucher yvaucher changed the title 17.0 mig graphql_base [17.0][MIG] graphql_base Sep 30, 2024
@yvaucher
Copy link
Member

@sbidoul Did you had the change to look at the issue you mentioned?

@sbidoul
Copy link
Member

sbidoul commented Oct 2, 2024

Tentative fix deployed in the bot. Let's try again.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-397-by-sbidoul-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 2, 2024
Signed-off-by sbidoul
@OCA-git-bot
Copy link
Contributor

@sbidoul The merge process could not be finalized, because command /tmp/tmpv6hxnk80/bin/python -P -m build --wheel --outdir /tmp/tmps9in4dgd --no-isolation /tmp/tmpm25ri6q4/graphql_base failed with output:

* Getting build dependencies for wheel...
* Building wheel...
Could not import runpy module
Traceback (most recent call last):
  File "<frozen runpy>", line 15, in <module>
  File "<frozen importlib.util>", line 16, in <module>
  File "/usr/lib/python3.12/threading.py", line 6, in <module>
    import functools
  File "/usr/lib/python3.12/functools.py", line 22, in <module>
    from types import GenericAlias
  File "/tmp/tmpm25ri6q4/graphql_base/types.py", line 4, in <module>
    import graphene
ModuleNotFoundError: No module named 'graphene'
Traceback (most recent call last):
  File "/tmp/tmpv6hxnk80/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
    main()
  File "/tmp/tmpv6hxnk80/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
    json_out["return_val"] = hook(**hook_input["kwargs"])
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpv6hxnk80/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 280, in build_wheel
    return _build_backend().build_wheel(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpv6hxnk80/lib/python3.12/site-packages/whool/buildapi.py", line 194, in build_wheel
    return _build_wheel(Path.cwd(), Path(wheel_directory), editable=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpv6hxnk80/lib/python3.12/site-packages/whool/buildapi.py", line 174, in _build_wheel
    subprocess.run(
  File "/usr/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/tmp/tmpv6hxnk80/bin/python', '-m', 'wheel', 'pack', '-d', '/tmp/tmps9in4dgd', '/tmp/tmpp05hmv1s']' returned non-zero exit status 1.

ERROR Backend subprocess exited when trying to invoke build_wheel

@sbidoul
Copy link
Member

sbidoul commented Oct 2, 2024

Hm, not good yet.

@lmignon
Copy link
Contributor

lmignon commented Oct 3, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

@lmignon The merge process could not start, because command `git merge --no-ff -m 'Merge PR #397 into 17.0

Signed-off-by lmignon' tmp-pr-397` failed with output:

Auto-merging .pre-commit-config.yaml
Auto-merging requirements.txt
CONFLICT (content): Merge conflict in requirements.txt
Automatic merge failed; fix conflicts and then commit the result.

@lmignon
Copy link
Contributor

lmignon commented Oct 3, 2024

@dduarte-odoogap Can you rebase please? I would like to try to merge it again.

@sbidoul
Copy link
Member

sbidoul commented Oct 3, 2024

I'll take care of this. There is a fundamental issue with this types.py at the repo root that is not easily solvable. I'll try renaming that file.

@sbidoul
Copy link
Member

sbidoul commented Oct 3, 2024

Superseded by #461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants