Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] extendable_fastapi: Registry corruption in tests #393

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Nov 7, 2023

Register the cleanup of the extendable registry just after its initialisation by calling the method from unittest. If setUpClass() fails, meaning that tearDownClass() is not called, then any cleanup functions added with a call to will still be called.

refs #392

Register the cleanup of the extendable registry just after its initialisation by calling the  method from unittest. If setUpClass() fails, meaning that tearDownClass() is not called, then any cleanup functions added with a call to  will still be called.

refs OCA#392
@lmignon lmignon changed the title ]16.0[FIX] extendable_fastapi: Registry corruption in tests [16.0][FIX] extendable_fastapi: Registry corruption in tests Nov 7, 2023
Copy link
Member

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@lmignon
Copy link
Contributor Author

lmignon commented Nov 7, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-393-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4fabd2d into OCA:16.0 Nov 7, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fecc1ef. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-fix-392 branch November 7, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants