-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] fastapi: optionally authenticated partner #387
[16.0] fastapi: optionally authenticated partner #387
Conversation
aac3160
to
812c0c0
Compare
f6bb9ab
to
639bdf7
Compare
639bdf7
to
ffa5342
Compare
ffa5342
to
593519a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review)
2765ec1
to
38b0bfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
38b0bfd
to
5e4b2e4
Compare
To ensure that exception orrurring outside of the fastapi processing stack are properly handled, implement the 'handle_error' method into the FastApiDispatcher class
Defines specific dependencies to support case where te authentication is optional.
5e4b2e4
to
792df9f
Compare
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 004b3b3. Thanks a lot for contributing to OCA. ❤️ |
@dreispt we should not merge this one....I should have put this PR in draft because I still want to check something. On further thought, the approach doesn't seem right. I'll revert it |
No description provided.