Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] fastapi: optionally authenticated partner #387

Merged
merged 2 commits into from
May 3, 2024

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Oct 31, 2023

No description provided.

@lmignon lmignon force-pushed the 16.0-optional-authenticated-partner branch from aac3160 to 812c0c0 Compare October 31, 2023 12:00
@lmignon lmignon changed the title [16.0] fastapi: optional authenticated partner [16.0] fastapi: optionally authenticated partner Oct 31, 2023
@lmignon lmignon force-pushed the 16.0-optional-authenticated-partner branch 2 times, most recently from f6bb9ab to 639bdf7 Compare October 31, 2023 16:19
@lmignon lmignon force-pushed the 16.0-optional-authenticated-partner branch from 639bdf7 to ffa5342 Compare November 3, 2023 13:55
@lmignon lmignon force-pushed the 16.0-optional-authenticated-partner branch from ffa5342 to 593519a Compare November 13, 2023 17:58
Copy link
Member

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@lmignon lmignon force-pushed the 16.0-optional-authenticated-partner branch 3 times, most recently from 2765ec1 to 38b0bfd Compare December 21, 2023 15:37
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@lmignon lmignon force-pushed the 16.0-optional-authenticated-partner branch from 38b0bfd to 5e4b2e4 Compare February 21, 2024 13:33
lmignon added 2 commits March 14, 2024 16:42
To ensure that exception orrurring outside of the fastapi processing stack are properly handled, implement the 'handle_error' method into the FastApiDispatcher class
Defines specific dependencies to support case where te authentication is optional.
@lmignon lmignon force-pushed the 16.0-optional-authenticated-partner branch from 5e4b2e4 to 792df9f Compare March 14, 2024 16:11
@dreispt
Copy link
Member

dreispt commented May 3, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-387-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 535f642 into OCA:16.0 May 3, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 004b3b3. Thanks a lot for contributing to OCA. ❤️

@lmignon
Copy link
Contributor Author

lmignon commented May 3, 2024

@dreispt we should not merge this one....I should have put this PR in draft because I still want to check something. On further thought, the approach doesn't seem right. I'll revert it

@sbidoul sbidoul deleted the 16.0-optional-authenticated-partner branch May 26, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants