Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] extendable_fastapi: Coercion must be possible #375

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Sep 19, 2023

On the StrictExtendableBaseModel, disable strict mode to enable coercion from json by FastAPI

On the StrictExtendableBaseModel, disable strict mode to enable coercion from json by FastAPI
@lmignon
Copy link
Contributor Author

lmignon commented Sep 19, 2023

ping @marielejeune @qgroulard

@lmignon
Copy link
Contributor Author

lmignon commented Sep 19, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-375-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 19, 2023
Signed-off-by lmignon
@OCA-git-bot
Copy link
Contributor

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-375-by-lmignon-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@lmignon
Copy link
Contributor Author

lmignon commented Sep 19, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-375-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 95da042 into OCA:16.0 Sep 19, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 84eaea2. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-allows-coercion-for-strict-model branch September 19, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants