[FIX] - base_rest: fix missing params #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @lmignon |
lmignon
reviewed
Aug 21, 2023
base_rest/components/service.py
Outdated
| @@ -151,7 +151,7 @@ def dispatch(self, method_name, *args, params=None): | |||
| :return: | |||
| """ | |||
| method = getattr(self, method_name, object()) | |||
| params = params or {} | |||
| params = params or request.get_json_data() or {} | |||
There was a problem hiding this comment.
@sbejaoui At this level, we should not use the request object. The parameters should be properly passed to the dispatch by callers. I've the feeling that the problem is upstream into the call stack.
sbejaoui
force-pushed
the
16.0-base_rest-sbj
branch
from
a4c523f to
5c08d8c
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
lmignon
added
no stale
|
closing since the fix is a workaround for a bug into shopfloor_base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.