[MIG] [16.0] base_graphql #323
Conversation
|
As I'm keen to see it in the v16, could be worth to ping @sbidoul :-) |
graphql_base/controllers/main.py
Outdated
| @@ -77,7 +61,7 @@ def _process_request(self, schema, data): | |||
| return response | |||
| except HttpQueryError as e: | |||
| result = json_encode({"errors": [{"message": str(e)}]}) | |||
| headers = dict(e.headers) | |||
| headers = dict() | |||
There was a problem hiding this comment.
The HttpQueryError does not contain any headers anymore
There was a problem hiding this comment.
I still see it here, though. And this does not seem to have changed recently.
|
Hm, dear bot, why did you not notify me about this PR, since I'm a maintainer of the migrated module? |
|
/ocabot migration graphql_base |
graphql_base/controllers/main.py
Outdated
| @@ -77,7 +61,7 @@ def _process_request(self, schema, data): | |||
| return response | |||
| except HttpQueryError as e: | |||
| result = json_encode({"errors": [{"message": str(e)}]}) | |||
| headers = dict(e.headers) | |||
| headers = dict() | |||
There was a problem hiding this comment.
Hm, it looks like e.headers can be None, so I suggest this:
| headers = dict() | |
| headers = dict(e.headers or {}) |
|
Thanks! /ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 14d1e69. Thanks a lot for contributing to OCA. ❤️ |
[MIG] [16.0] base_graphql