Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] report.py: docids = none #791

Merged
merged 1 commit into from
Nov 18, 2023
Merged

[16.0][FIX] report.py: docids = none #791

merged 1 commit into from
Nov 18, 2023

Conversation

TennyMkt
Copy link
Contributor

resolves #790

@TennyMkt TennyMkt changed the title fix for report.py per docids = none [16.0][FIX] report.py: docids = none Sep 14, 2023
danall59
danall59 approved these changes Sep 15, 2023
View reviewed changes
Copy link

@danall59 danall59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has been verified and tested.
Merging is recommended.
It's OK!

@TennyMkt TennyMkt mentioned this pull request Sep 18, 2023
Closed
andreampiovesana
andreampiovesana approved these changes Sep 21, 2023
View reviewed changes
Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TennyMkt TennyMkt mentioned this pull request Sep 21, 2023
Merged
SirAionTech
SirAionTech approved these changes Oct 3, 2023
View reviewed changes
Copy link

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
A test case covering this fix would be great, but since this is just one line it looks already good to me as is.

Note that the core does something similar in
https://github.com/odoo/odoo/blob/114e31521beb1d00f85f8a19959006dfe62708a0/addons/web/controllers/report.py#L31-L32

@dreispt
Copy link
Member

dreispt commented Nov 18, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-791-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9e301d0 into OCA:16.0 Nov 18, 2023
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 18ac3ad. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech approved these changes

@danall59 danall59 danall59 approved these changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[16.0] [BUG] report_routes with no docids
6 participants
@TennyMkt @dreispt @OCA-git-bot @andreampiovesana @danall59 @SirAionTech