Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][FIX] report_xls: Move description to first line #66

Merged
merged 1 commit into from
Nov 17, 2016

Conversation

lasley
Copy link

@lasley lasley commented Aug 12, 2016

I'm not sure why the RunBot builds are failing on a non-installable module, but they are and it's killing my OCD.

This is minimalistic change that hopefully fixes the builds.

@@ -26,8 +26,7 @@
'author': "Noviat,Odoo Community Association (OCA)",
'website': 'http://www.noviat.com',
'category': 'Reporting',
'description': """
Excel report engine
'description': """Excel report engine

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply remove the description key. This is not mandatory anymore with the README file.
(even more this becomes redundant and difficult to keep in sync)

Copy link
Author

@lasley lasley Aug 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this instance there isn't a ReadMe, and I was trying to keep the change-set minimal as this isn't a full conversion & I am just trying to fix the build (all 9.0 PRs are failing right now). If this is a block however, I will move this over to a ReadMe using OCA template.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can cherry-commit fddca41 from 8.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent call, thanks @pedrobaeza

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could remove the description field as README.rst was added

@lasley
Copy link
Author

lasley commented Aug 26, 2016

Oops forgot to drop a note saying comments handled after handling comments. Comments handled! 😄

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the module is not yet merged, but we can fast-track it anyway.

@pedrobaeza pedrobaeza merged commit e6be6c7 into OCA:9.0 Nov 17, 2016
@lasley lasley deleted the hotfix/build-error branch November 17, 2016 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants