-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0][FIX] report_xls: Move description to first line #66
Conversation
@@ -26,8 +26,7 @@ | |||
'author': "Noviat,Odoo Community Association (OCA)", | |||
'website': 'http://www.noviat.com', | |||
'category': 'Reporting', | |||
'description': """ | |||
Excel report engine | |||
'description': """Excel report engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply remove the description key. This is not mandatory anymore with the README file.
(even more this becomes redundant and difficult to keep in sync)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this instance there isn't a ReadMe, and I was trying to keep the change-set minimal as this isn't a full conversion & I am just trying to fix the build (all 9.0 PRs are failing right now). If this is a block however, I will move this over to a ReadMe using OCA template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can cherry-commit fddca41 from 8.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent call, thanks @pedrobaeza
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could remove the description field as README.rst was added
4324c6c
to
fa3c995
Compare
Oops forgot to drop a note saying comments handled after handling comments. Comments handled! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the module is not yet merged, but we can fast-track it anyway.
I'm not sure why the RunBot builds are failing on a non-installable module, but they are and it's killing my OCD.
This is minimalistic change that
hopefullyfixes the builds.