Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] kpi #409

Merged
merged 18 commits into from
May 15, 2021
Merged

[13.0][MIG] kpi #409

merged 18 commits into from
May 15, 2021

Conversation

flachica
Copy link

@flachica flachica commented Jun 4, 2020

No description provided.

naousse and others added 17 commits June 4, 2020 14:09
* kpi migration to odoo 9
* UI error connected
* Correction base on last maxime review
* correction on @elicoidal review
* Warning exception improve in kpi_threshold
* Latest Ellicoidal comment implemented
* last Ellicoial recommendation done.
* Copyright corrected
Currently translated at 100.0% (68 of 68 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-12.0/reporting-engine-12.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/
Currently translated at 100.0% (79 of 79 strings)

Translation: reporting-engine-12.0/reporting-engine-12.0-kpi
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/pt_BR/
@flachica flachica mentioned this pull request Jun 4, 2020
13 tasks
@flachica
Copy link
Author

I think that the odoo.conf of travis is not correct. base_external_dbsource not finded here https://travis-ci.org/github/OCA/reporting-engine/jobs/694682931#L774 because this repo not in oca_dependencies. If I PR this file, It be corrected automatically?

@etobella
Copy link
Member

etobella commented Jul 7, 2020

You must add server-backend

@flachica
Copy link
Author

Added

kpi/__manifest__.py Outdated Show resolved Hide resolved
kpi/models/kpi_threshold_range.py Outdated Show resolved Hide resolved
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed 👍 LGTM

Copy link

@albariera albariera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review LGTM 👍

@dreispt
Copy link
Member

dreispt commented May 15, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-409-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eec5479 into OCA:13.0 May 15, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4c6d57d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants