Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] queue_job_subscribe: Migration to 18.0 #695

Merged
merged 24 commits into from
Oct 19, 2024

Conversation

thienvh332
Copy link
Contributor

No description provided.

@thienvh332 thienvh332 marked this pull request as ready for review October 7, 2024 10:07
@simahawk
Copy link
Contributor

simahawk commented Oct 7, 2024

/ocabot migration queue_job_subscribe

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 7, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 7, 2024
5 tasks
class TestJobSubscribe(common.TransactionCase):
def setUp(self):
super().setUp()
grp_queue_job_manager = self.ref("queue_job.group_queue_job_manager")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please disable tracking and use no_reset_password when creating users? (or use odoo.tests.common.new_test_user.
To be done in a separated commit that can be backported.

self.assertIn(self.other_partner_b.id, followers_id)

###########################################
# Test 2: User b request to not be follower
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is a completely different test, it should be split

@thienvh332 thienvh332 force-pushed the 18.0-mig-queue_job_subscribe branch from d266c1d to 1c7898d Compare October 10, 2024 10:09
@thienvh332 thienvh332 requested a review from simahawk October 10, 2024 10:13
@simahawk
Copy link
Contributor

@thienvh332 pls rebase and drop test req

sbidoul and others added 22 commits October 18, 2024 14:55
- set module uninstallable
- add new .dot file config for v14
Currently translated at 100.0% (5 of 5 strings)

Translation: queue-17.0/queue-17.0-queue_job_subscribe
Translate-URL: https://translation.odoo-community.org/projects/queue-17-0/queue-17-0-queue_job_subscribe/it/
Currently translated at 100.0% (5 of 5 strings)

Translation: queue-17.0/queue-17.0-queue_job_subscribe
Translate-URL: https://translation.odoo-community.org/projects/queue-17-0/queue-17-0-queue_job_subscribe/zh_CN/
Currently translated at 100.0% (5 of 5 strings)

Translation: queue-17.0/queue-17.0-queue_job_subscribe
Translate-URL: https://translation.odoo-community.org/projects/queue-17-0/queue-17-0-queue_job_subscribe/pt_BR/
@thienvh332 thienvh332 force-pushed the 18.0-mig-queue_job_subscribe branch from 1c7898d to 00345e5 Compare October 18, 2024 07:56
@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-695-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c59655d into OCA:18.0 Oct 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 46cdae3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.