-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][BCK] queue_job: unify no delay option / unified views / don't raise warning for valid context #682
Open
rousseldenis
wants to merge
4
commits into
OCA:12.0
Choose a base branch
from
acsone:oca-port-pr-680-from-14.0-to-12.0
base: 12.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current situation: * multiple keys for no good reason * half baked: not all of them used everywhere * no centralization * poor naming With this change we'll have: * 1 and only one key to disable via ctx: ``queue_job__no_delay`` * 1 and only one key to disable via os env: ``QUEUE_JOB__NO_DELAY`` * backward compatibility with deprecation for old keys
Hi @guewen, |
Split one model per file, as advised in the contribution guide.
rousseldenis
force-pushed
the
oca-port-pr-680-from-14.0-to-12.0
branch
from
September 10, 2024 08:11
8859896
to
77d6da1
Compare
rousseldenis
force-pushed
the
oca-port-pr-680-from-14.0-to-12.0
branch
from
September 10, 2024 08:15
77d6da1
to
165508c
Compare
rousseldenis
changed the title
[BCK] queue_job: unify no delay option
[BCK] queue_job: unify no delay option / unified views / don't raise warning for valid context
Sep 10, 2024
rousseldenis
changed the title
[BCK] queue_job: unify no delay option / unified views / don't raise warning for valid context
[12.0][BCK] queue_job: unify no delay option / unified views / don't raise warning for valid context
Sep 10, 2024
As the 'queue_job__no_delay' context key is the valid one to use, don't raise warnings during tests, but log it as information level.
rousseldenis
force-pushed
the
oca-port-pr-680-from-14.0-to-12.0
branch
from
September 10, 2024 08:29
c88ac06
to
f328bde
Compare
gurneyalex
approved these changes
Sep 30, 2024
hparfr
approved these changes
Sep 30, 2024
This PR has the |
FrancoMaxime
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported :