Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [IMP] queue_job: HA job runner using session level advisory lock #673

Open
wants to merge 4 commits into
base: 17.0
Choose a base branch
from

Conversation

qgroulard
Copy link
Contributor

Forward port of #668

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LoisRForgeFlow
Copy link
Contributor

@guewen @sbidoul anything missing to get this one merged?

@simahawk
Copy link
Contributor

simahawk commented Dec 6, 2024

It has been approved by @guewen here as well #668 yet @sbidoul had to provide feedback on odoo.sh if I'm not mistaken.

@sbidoul
Copy link
Member

sbidoul commented Dec 6, 2024

We deployed this on a 17.0 odoo.sh instance. It works and nobody yelled at us :)

Now this is not a high volume deployment.

I'm quite confident this PR is good, but we are going to deploy this on a couple of more intensive instances (not odoo.sh) to confirm. I would encourage others to to the same.

Without this, we leak connections to Databases that don't have queue_job
installed.
Without this we risk connection leaks in case of exceptions in the
constructor.
@sbidoul sbidoul force-pushed the 17.0-forwardport-ha_runner-qgr branch from 918a966 to 992bc9b Compare December 6, 2024 08:44
@sbidoul
Copy link
Member

sbidoul commented Dec 6, 2024

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants