-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0] [ADD] ability to set jobs to done in batch #59
Conversation
@guewen do you think this could be needed to all? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense, and you can anyway requeue any jobs in done state, thus it gives you a better control.
Current work around are either to edit state in DB or to install mass_update module.
In batch changes I've also find myself doing a lot of eta
edition. But that would be for an other feature.
queue_job/views/queue_job_views.xml
Outdated
</group> | ||
<footer> | ||
<button name="set_done" string="Set to done" type="object" class="oe_highlight"/> | ||
or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The or
is the old fashion design of wizards in version 7.0 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. If you can remove the or
in the wizard it'd be very nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ecino Thank you for this useful improvement. Can you remove the 'or' so we can merge your changes?
In our production database, we have a lot of failed jobs that we only need to put as done, because there is no real other action to do. For us, it's boring to go through all the form views and mark the jobs as done.
We therefore propose to add a small wizard to mark as done in batch, as it already exists for requeing jobs.