Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0] [ADD] ability to set jobs to done in batch #59

Merged
merged 1 commit into from
Jun 20, 2018
Merged

[10.0] [ADD] ability to set jobs to done in batch #59

merged 1 commit into from
Jun 20, 2018

Conversation

ecino
Copy link

@ecino ecino commented Feb 22, 2018

In our production database, we have a lot of failed jobs that we only need to put as done, because there is no real other action to do. For us, it's boring to go through all the form views and mark the jobs as done.

We therefore propose to add a small wizard to mark as done in batch, as it already exists for requeing jobs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 78.401% when pulling 4b7767d on CompassionCH:10.0 into 5c098fc on OCA:10.0.

@coveralls
Copy link

coveralls commented Feb 22, 2018

Coverage Status

Coverage decreased (-0.1%) to 77.669% when pulling 54f96ea on CompassionCH:10.0 into 10b73c1 on OCA:10.0.

@ecino
Copy link
Author

ecino commented Apr 20, 2018

@guewen do you think this could be needed to all?

Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, and you can anyway requeue any jobs in done state, thus it gives you a better control.

Current work around are either to edit state in DB or to install mass_update module.

In batch changes I've also find myself doing a lot of eta edition. But that would be for an other feature.

</group>
<footer>
<button name="set_done" string="Set to done" type="object" class="oe_highlight"/>
or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The or is the old fashion design of wizards in version 7.0 :)

Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. If you can remove the or in the wizard it'd be very nice.

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ecino Thank you for this useful improvement. Can you remove the 'or' so we can merge your changes?

@ecino
Copy link
Author

ecino commented May 25, 2018

@lmignon @guewen Done!

@yvaucher yvaucher merged commit 1017b1b into OCA:10.0 Jun 20, 2018
@ecino ecino deleted the 10.0 branch June 22, 2018 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants