Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Get attributes on the class instead of recordsets #50

Merged
merged 1 commit into from
Feb 8, 2018
Merged

[FIX] Get attributes on the class instead of recordsets #50

merged 1 commit into from
Feb 8, 2018

Commits on Feb 6, 2018

  1. [FIX] Get attributes on the class instead of recordsets 

    Even if the recordset is empty, this is still an instance of the class,
so the @Property methods are called. As this type of method is usually
run on a single record, they need self.ensure_one(), which crashes when
evaluated on a recordset, preventing the server to start when queue_job
is installed.

Getting the attributes on the class itself instead of using an empty
recordset avoids evaluating property methods.

This reverts commit 49d8f37.
    Sylvain GARANCHER committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    4ebb245 View commit details
    Browse the repository at this point in the history