[ADD] missing-import-error, missing-manifest-dependency #68
Conversation
| # self-odoo | ||
| 'odoo', 'openerp', | ||
| # Known external packages of odoo | ||
| 'PIL', 'babel', 'dateutil', 'decorator', 'docutils', 'jinja2', 'ldap', |
There was a problem hiding this comment.
Shouldn't this be caught from the requirements.txt of Odoo?
There was a problem hiding this comment.
That was my first option
- But for many cases the
pip install packageis different toimport package
But I have extracted the packages running this check from odoo 8.0, 9.0 and master:
PYTHONPATH=~/build/OCA/pylint-odoo pylint --msg-template="{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}" -d all -e missing-import-error --load-plugins=pylint_odoo odoo/addons/* odoo/openerp/addons/* odoo odoo/openerp -rn
There was a problem hiding this comment.
Sorry, I didn't see this. Anyways, we need to control a different list depending versions. What about including this on the specific cfg for each version?
There was a problem hiding this comment.
(Don't worry.)
Yes, that is the intention.
Here we have a "Default" value for initial assignation from configuration file.
But we can create a configuration file by each version with this value but is from running step MQT configuration files of pylint
| @@ -229,15 +259,71 @@ def check_odoo_relative_import(self, node): | |||
| self.add_message('odoo-addons-relative-import', node=node, | |||
| args=(self.odoo_module_name)) | |||
|
|
|||
| @utils.check_messages('odoo-addons-relative-import') | |||
| @staticmethod | |||
| def _is_absoulte_import(node, name): | |||
moylop260
force-pushed
the
master-oca-whlst-pack-moy3
branch
from
162f7b1 to
90739a6
Compare
|
👍 |
1 similar comment
|
👍 |
moylop260
changed the title
moylop260
force-pushed
the
master-oca-whlst-pack-moy3
branch
2 times, most recently
from
d3dd205 to
e06171e
Compare
|
Could we merge it? |
|
You didn't answer me about the possibility of extracting known libraries from requirements.txt so that we can correctly parse them when this changes through versions. |
|
Are you talking about my last answer #68 (comment)? |
|
Thanks as always for your good job. |
|
Thanks for your review, feedback and merge! |
[ADD] missing-import-error, missing-manifest-dependency
[ADD] missing-import-error, missing-manifest-dependency
* Merge pull request OCA#68 from vauxoo-dev/master-oca-whlst-pack-moy3 * [REF] import-error: Increase test expected
Based on external dependencies guideline
Inspired from OCA/maintainer-tools#224
FYI the variable
DFLT_IMPORT_NAME_WHITELISTwas filled running this check on odoo/odoo#master..odoo/odoo#8.0PYTHONPATH=~/build/OCA/pylint-odoo pylint --msg-template="{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}" -d all -e missing-import-error --load-plugins=pylint_odoo odoo/addons/* odoo/openerp/addons/* odoo odoo/openerp -rn