Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] pylint_odoo: Detect the children inside the odoo xml #156

Merged
merged 1 commit into from
Sep 25, 2017
Merged

[FIX] pylint_odoo: Detect the children inside the odoo xml #156

merged 1 commit into from
Sep 25, 2017

Conversation

JesusZapata
Copy link
Member

Detect the children inside the odoo xml tag and only active the check deprecated-data-xml-node when exist one tag data inside de xml

This fix skip the follow case

<odoo>
    <data noupdate="1">
        <record></record>
    </data>
    <record></record>
</odoo>

I run this change over the module of odoo sales_team

Without this change the output is the follow
image
The pylint-odoo detect four files

After apply this change over the code the output is the follow
image
The pylint-odoo detect two files

Fix Vauxoo#128

@JesusZapata
Copy link
Member Author

@moylop260
This OCA PR is related with this other PR on Vauxoo#129

@moylop260
Copy link
Collaborator

@naglis @lasley Could you review it, please?
@JesusZapata could you review the red travis build's status?

naglis
naglis approved these changes Sep 22, 2017
View reviewed changes
Copy link
Contributor

@naglis naglis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Travis seems to be failing due to #150 not being merged in @JesusZapata's branch. Should be OK once it's updated from master.

@JesusZapata JesusZapata force-pushed the master-oca-one-data-node-jesuszapata branch from 6804a0d to e967a71 Compare September 25, 2017 15:03
@JesusZapata
Copy link
Member Author

I made the rebase with the master branch and now the travis is green

@moylop260 moylop260 merged commit 43a5af5 into OCA:master Sep 25, 2017
@moylop260 moylop260 deleted the master-oca-one-data-node-jesuszapata branch September 25, 2017 15:19
This was referenced Oct 5, 2017
Closed
Closed
@antonag32 antonag32 mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasley lasley lasley approved these changes

@naglis naglis naglis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XML with noupdate="1" and noupdate="0"
4 participants
@JesusZapata @moylop260 @naglis @lasley