[11.0] [MIG] purchase_request_department #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HviorForgeFlow
force-pushed
the
11.0-mig-purchase_request_department
branch
from
e27e4f0 to
8c8f2e1
Compare
|
All comments attended @nikul-serpentcs @jbeficent . |
HviorForgeFlow
force-pushed
the
11.0-mig-purchase_request_department
branch
from
8c8f2e1 to
515e00d
Compare
HviorForgeFlow
force-pushed
the
11.0-mig-purchase_request_department
branch
from
515e00d to
030bccf
Compare
JayVora-SerpentCS
suggested changes
Nov 24, 2018
| def _get_my_department(self): | ||
| employees = self.env.user.employee_ids | ||
| return (employees[0].department_id if employees | ||
| else self.env['hr.department']) |
There was a problem hiding this comment.
does not this return env object and not Id False for the default to digest ?
There was a problem hiding this comment.
What should it be done to solve this?? @JayVora-SerpentCS
There was a problem hiding this comment.
IMHO, return (employees[0].department_id if employees else False) should do. I could be wrong, but you may check.
JordiBForgeFlow
force-pushed
the
11.0-mig-purchase_request_department
branch
from
030bccf to
525cd4d
Compare
HviorForgeFlow
force-pushed
the
11.0-mig-purchase_request_department
branch
2 times, most recently
from
775286c to
71a8c91
Compare
oca_dependencies.txt
Outdated
| @@ -1,3 +1,5 @@ | |||
| server-tools | |||
| product-attribute | |||
| server-ux | |||
| hr | |||
| purchase-workflow https://github.com/Eficent/purchase-workflow.git 11.0-mig-purchase_request | |||
There was a problem hiding this comment.
dependency merged, can you remove this and rebase?
HviorForgeFlow
force-pushed
the
11.0-mig-purchase_request_department
branch
from
71a8c91 to
294fa5d
Compare
|
Update review |
nikul-serpentcs
approved these changes
Dec 17, 2018
54 tasks
JordiBForgeFlow
force-pushed
the
11.0-mig-purchase_request_department
branch
from
294fa5d to
00630e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 11. Minor changes.