Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] purchase_date_planned_manual #597

Merged
merged 6 commits into from
Nov 9, 2018
Merged

[11.0][MIG] purchase_date_planned_manual #597

merged 6 commits into from
Nov 9, 2018

Conversation

LoisRForgeFlow
Copy link
Contributor

Migration to v11.

@LoisRForgeFlow LoisRForgeFlow force-pushed the 11.0-mig-purchase_date_planned_manual branch from 9a8e9ac to ecd824e Compare October 18, 2018 09:59
nikul-serpentcs
nikul-serpentcs reviewed Oct 19, 2018
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

purchase_date_planned_manual/tests/test_date_planned_manual.py Outdated Show resolved Hide resolved
purchase_date_planned_manual/tests/test_date_planned_manual.py Outdated Show resolved Hide resolved
@LoisRForgeFlow LoisRForgeFlow force-pushed the 11.0-mig-purchase_date_planned_manual branch from ecd824e to 9aa014a Compare October 19, 2018 14:17
@LoisRForgeFlow
Copy link
Contributor Author

@nikul-serpentcs Please, update your review.

nikul-serpentcs
nikul-serpentcs approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM

HviorForgeFlow
HviorForgeFlow approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + functional review. It works as expected. 👍

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JordiBForgeFlow JordiBForgeFlow merged commit a266f4a into OCA:11.0 Nov 9, 2018
@MiquelRForgeFlow MiquelRForgeFlow deleted the 11.0-mig-purchase_date_planned_manual branch November 9, 2018 15:03
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 29, 2018
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LoisRForgeFlow @nikul-serpentcs @MiquelRForgeFlow @HviorForgeFlow @JordiBForgeFlow @oca-transbot @oca-travis