Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] purchase_order_archive #2267

Merged
merged 30 commits into from
May 15, 2024
Merged

[17.0][MIG] purchase_order_archive #2267

merged 30 commits into from
May 15, 2024

Conversation

MarioLM-23
Copy link

Standar migration with changes in view and improving test

astirpe and others added 29 commits May 6, 2024 11:10
@astirpe
[11.0][ADD] purchase_order_archive
c7a8781
@OCA-git-bot
[UPD] README.rst
9e08408
@oca-travis
[UPD] Update purchase_order_archive.pot
c711003
@astirpe
[12.0][MIG] purchase_order_archive
8ef6666
@OCA-git-bot
[UPD] README.rst
802c1c3
@oca-travis
[UPD] Update purchase_order_archive.pot
83dee24
@OCA-git-bot
[UPD] README.rst
22e5c48
@liweijie0812
Added translation using Weblate (Chinese (Simplified))
11a4309
@liweijie0812
Translated using Weblate (Chinese (Simplified))
a950ec5 
Currently translated at 100.0% (3 of 3 strings)

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_archive/zh_CN/
@astirpe
[13.0][MIG] purchase_order_archive
dc13e2e
@oca-travis
[UPD] Update purchase_order_archive.pot
a8e7295
@OCA-git-bot
[UPD] README.rst
fddc48e
@oca-transbot
Update translation files
9a2c87b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_order_archive/
@OCA-git-bot
pre-commit update
191461b
@dong-z
Translated using Weblate (Chinese (Simplified))
5f6345a 
Currently translated at 100.0% (4 of 4 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_order_archive/zh_CN/
@astirpe
[14.0][MIG] purchase_order_archive
595c759
@oca-travis
[UPD] Update purchase_order_archive.pot
bc5d037
@OCA-git-bot
[UPD] README.rst
d78c5ec
@victoralmau
[IMP] purchase_order_archive: Improve filters (add to all search view…
7ae7071 
…s + add active filter)

TT44770
[UPD] Update purchase_order_archive.pot
d68a580
@OCA-git-bot
purchase_order_archive 14.0.1.1.0
12226c8
@weblate
Update translation files
cd1b9c4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_order_archive/
@OCA-git-bot
[UPD] README.rst
63b23e4
@CLaurelB
[MIG] purchase_order_archive: Migration to 16.0
53daf64
[UPD] Update purchase_order_archive.pot
339d84b
@weblate
Update translation files
ce5ee2d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_archive/
@mymage
Added translation using Weblate (Italian)
3cd6c7c
@mymage
Translated using Weblate (Italian)
0072938 
Currently translated at 100.0% (4 of 4 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_archive
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_archive/it/
[IMP] purchase_order_archive: pre-commit auto fixes
b26098d
@MarioLM-23 MarioLM-23 force-pushed the 17.0-mig-purchase_order_archive branch from 6ca8cc1 to 89eee6d Compare May 6, 2024 11:21
@MarioLM-23 MarioLM-23 mentioned this pull request May 6, 2024
Open
51 tasks
Anxo82
Anxo82 suggested changes May 8, 2024
View reviewed changes
Copy link

@Anxo82 Anxo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

purchase_order_archive/views/purchase_order.xml Outdated Show resolved Hide resolved
@MarioLM-23
Copy link
Author

@Anxo82 Done!

@MarioLM-23 MarioLM-23 requested a review from Anxo82 May 8, 2024 14:22
Anxo82
Anxo82 approved these changes May 8, 2024
View reviewed changes
Copy link

@Anxo82 Anxo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

To finish u need squash commit

ChristianSantamaria
ChristianSantamaria approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@ChristianSantamaria ChristianSantamaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@MarioLM-23 MarioLM-23 force-pushed the 17.0-mig-purchase_order_archive branch from d9434f0 to 10bd48a Compare May 8, 2024 14:37
@MarioLM-23
Copy link
Author

LGTM 👍

To finish u need squash commit

Ready, thank you for the review

@ChristianSantamaria
Copy link
Contributor

@mariobinhex In 10bd48a no description should be added to the MIG commit
Then this PR is Done, i'm sorry for making so much change ty 😄

@MarioLM-23 MarioLM-23 force-pushed the 17.0-mig-purchase_order_archive branch from 10bd48a to 7761359 Compare May 10, 2024 10:51
@MarioLM-23
Copy link
Author

@mariobinhex In 10bd48a no description should be added to the MIG commit Then this PR is Done, i'm sorry for making so much change ty 😄

Done! Don't worry and thanks for the change

HviorForgeFlow
HviorForgeFlow approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2267-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 31cef21 into OCA:17.0 May 15, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 294851d. Thanks a lot for contributing to OCA. ❤️

celm1990
celm1990 reviewed May 15, 2024
View reviewed changes
purchase_order_archive/readme/DESCRIPTION.md
Comment on lines +8 to +10
This module only depends on module purchase, but it could be used in
combination with OCA module 'record_archiver' in order to automatically
archive old purchase orders.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is outdated. The record_archiver module has not been migrated from V11, so it might be useful to remove this paragraph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celm1990 celm1990 celm1990 left review comments

@Anxo82 Anxo82 Anxo82 approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@ChristianSantamaria ChristianSantamaria ChristianSantamaria approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.