[FIX] product_configurator_mrp_component: configurable component selection and variant creation #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixes issue where if config component only has a few values in an attribute and the parent selects the values that the comp doesn't have, then don't create and add the component. This was causing an error because it was trying to create the variant even if the value selected didn't apply to the config component. This will allow more flexibility with config components. 2. Fixes issue where the available config components that show in the drop down will allow if the first attribute only had a few of the values but any attribute below that would have to have all the values in order for it to show.
dreispt
changed the title
dreispt
approved these changes
Mar 22, 2022
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at aaac433. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where if config component only has a few values in an attribute and the parent has and the selected value is not in the configurable component, an error would be raised. The fix is don't create and add the component if this is the case. This was causing an error because it was trying to create the variant even if the value selected didn't apply to the config component. This will allow more flexibility with config components.
Fixes issue where the available configuration components that show in the drop down wasn't showing all the compatible product templates. It would show if the first attribute only had a few of the values but any attribute below that would have to have all the values in order for it to show.