Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [NEW] product_configurator_mrp_component: Added new module. #55

Merged

Conversation

Chandresh-OSI
Copy link
Contributor

No description provided.

@Chandresh-OSI Chandresh-OSI changed the title [14.0] [NEW] product_configurator_mrp_component: Added new module. [14.0] [NEW] [WIP] product_configurator_mrp_component: Added new module. Jan 18, 2022
@patrickrwilson patrickrwilson force-pushed the 14.0_new_product_configurator_mrp_component branch from 4d139cb to 13b56cc Compare January 25, 2022 21:53
@patrickrwilson patrickrwilson force-pushed the 14.0_new_product_configurator_mrp_component branch from e3e1c79 to d141569 Compare February 10, 2022 16:51
@Chandresh-OSI Chandresh-OSI changed the title [14.0] [NEW] [WIP] product_configurator_mrp_component: Added new module. [14.0] [NEW] product_configurator_mrp_component: Added new module. Feb 15, 2022
@Chandresh-OSI Chandresh-OSI marked this pull request as ready for review February 15, 2022 14:18
@patrickrwilson
Copy link
Contributor

@dreispt can you review? we aren't sure why pre-commit is red.

@patrickrwilson patrickrwilson force-pushed the 14.0_new_product_configurator_mrp_component branch from 58d21a0 to 97b035a Compare February 16, 2022 15:39
[UPD] Updated code with working items.

[UPD] Improved logic and added config component domain

[UPD] Added readme and default qty

[UPD] pre-commit

[UPD] pre-commit

[UPD] pre-commit

Allow search config component by internal ref

Update product_configurator_mrp_component/models/mrp_bom_line_config.py

pre-commit

[ADD] Added filter

change configurable component availability

Changes the logic of the configurable components domain. It now first checks that the child has all the attributes on the parent, and if so it then makes sure that the child has all the values for that line in the parent. This should allow a child which can have more values then the parent to still be added as a configurable component.

Co-Authored-By: Daniel Reis <[email protected]>
@patrickrwilson patrickrwilson force-pushed the 14.0_new_product_configurator_mrp_component branch from a9d5df7 to 0429d3b Compare February 23, 2022 21:23
@dreispt
Copy link
Member

dreispt commented Feb 24, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-55-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 30d79ae into OCA:14.0 Feb 24, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d20cfe6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants