[14.0][IMP] Add operations to the new BOM created by the configurator (When the Master BOM has Operations) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreispt
approved these changes
Dec 3, 2021
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| { | |||
| "name": "Product Configurator Manufacturing", | |||
| "version": "14.0.1.2.0", | |||
| "version": "14.0.1.2.1", | |||
There was a problem hiding this comment.
No need to bump version, the merge bot will do that for you.
| @@ -109,7 +119,7 @@ def test_01_action_config_start(self): | |||
| context | |||
| ) | |||
| self._configure_product_nxt_step() | |||
| # self.assertEqual( | |||
|
|
|||
There was a problem hiding this comment.
Why delete only the first line of the commented statement?
| "name": "Operation 1", | ||
| "workcenter_id": self.workcenter_id.id, | ||
| } | ||
| ) |
There was a problem hiding this comment.
Kudos for touching the tests!
Now if we could only add the check that the operations were really copied, that would be the cherry on top of the cake.
There was a problem hiding this comment.
@dreispt , Yeah but testcase file is on commented.
…t should copy over the operations from the master BOM
Vimal-OSI
force-pushed
the
14.0-IMP-allow-operatiion-line-for-existing-configure-bom
branch
from
ea1815f to
3cd6b47
Compare
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 89103d5. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.