[MIG][9.0] product_sequence #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs label change to "needs review" |
|
👍 |
| Usage | ||
| ===== | ||
|
|
||
| #. Go to ... |
There was a problem hiding this comment.
Please include short usage instructions
|
Please include some tests. |
atchuthan
force-pushed
the
9.0-product_sequence
branch
5 times, most recently
from
c92c088 to
9cb8dbb
Compare
| # -*- coding: utf-8 -*- | ||
| # © 2004 Tiny SPRL | ||
| # © 2016 Sodexis | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from . import models | ||
| from .models.product_product import update_null_and_slash_codes |
There was a problem hiding this comment.
You should change this also to a post/pre_init_hook.
|
Please update .travis.yml definition to get a correct Travis status |
atchuthan
force-pushed
the
9.0-product_sequence
branch
from
9cb8dbb to
9d20322
Compare
|
@pedrobaeza corrections done |
|
Why the coverage drop? You can test the init_hook creating a product, emptying by SQL the code, executing the hook and checking that is filled with the expected value. |
|
@pedrobaeza added test and fixed your points. COVERAGE DECREASED (-0.9%) TO 94.382%.. This seems alright to me :) |
pedrobaeza
approved these changes
Oct 24, 2016
atchuthan
pushed a commit
to sodexis/product-attribute
that referenced
this pull request
Oct 24, 2016
atchuthan
pushed a commit
to sodexis/product-attribute
that referenced
this pull request
Oct 24, 2016
LoisRForgeFlow
pushed a commit
to ForgeFlow/product-attribute
that referenced
this pull request
Mar 20, 2018
LoisRForgeFlow
pushed a commit
to ForgeFlow/product-attribute
that referenced
this pull request
Mar 20, 2018
LoisRForgeFlow
pushed a commit
to ForgeFlow/product-attribute
that referenced
this pull request
Mar 20, 2018
JordiBForgeFlow
pushed a commit
to ForgeFlow/product-attribute
that referenced
this pull request
May 14, 2018
BT-mgomez
referenced
this pull request
in brain-tec/product-attribute
Jul 12, 2018
ghost
pushed a commit
to camptocamp/product-attribute
that referenced
this pull request
Jul 23, 2018
ghost
pushed a commit
to camptocamp/product-attribute
that referenced
this pull request
Jul 23, 2018
ghost
pushed a commit
to camptocamp/product-attribute
that referenced
this pull request
Jul 23, 2018
sudhir-erpharbor
pushed a commit
to sudhir-erpharbor/product-attribute
that referenced
this pull request
Dec 6, 2018
Tardo
pushed a commit
to Tecnativa/product-attribute
that referenced
this pull request
Sep 27, 2019
Tardo
pushed a commit
to Tecnativa/product-attribute
that referenced
this pull request
Sep 27, 2019
sergio-teruel
pushed a commit
to Tecnativa/product-attribute
that referenced
this pull request
Jan 21, 2020
watthanun
pushed a commit
to ecosoft-odoo/product-attribute
that referenced
this pull request
Nov 20, 2020
BertVGroenendael
pushed a commit
to BertVGroenendael/product-attribute
that referenced
this pull request
Mar 18, 2022
marielejeune
pushed a commit
to acsone/product-attribute
that referenced
this pull request
Sep 15, 2022
marielejeune
pushed a commit
to acsone/product-attribute
that referenced
this pull request
Oct 4, 2022
marielejeune
pushed a commit
to acsone/product-attribute
that referenced
this pull request
Oct 19, 2022
dsolanki-initos
pushed a commit
to Nitrokey/odoo-product-attribute
that referenced
this pull request
Dec 12, 2022
NICO-SOLUTIONS
pushed a commit
to NICO-SOLUTIONS/product-attribute
that referenced
this pull request
Nov 21, 2023
dc-oerp
pushed a commit
to oerp-canada/product-attribute
that referenced
this pull request
Jul 19, 2024
dc-oerp
pushed a commit
to oerp-canada/product-attribute
that referenced
this pull request
Jul 19, 2024
chrisb-c01
pushed a commit
to codeforward-bv/product-attribute
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.