Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [mig] pos_hide_banknote_button #631

Merged
merged 7 commits into from
Jul 8, 2021
Merged

[14.0] [mig] pos_hide_banknote_button #631

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
33b7386
[ADD] pos_hide_banknote_button
legalsylvain Sep 9, 2020
eabd1d2
[UPD] Update pos_hide_banknote_button.pot
oca-travis Sep 10, 2020
29f06b6
[UPD] README.rst
OCA-git-bot Sep 10, 2020
bbeb8a9
[ADD] icon.png
OCA-git-bot Sep 10, 2020
23149b3
Added translation using Weblate (Spanish)
danimv5 Oct 26, 2020
bfabf76
[IMP] pos_hide_banknote_button: isort, black, prettier.
dsolanki-initos Apr 27, 2021
593df4e
[MIG] Migrate module pos_hide_banknote_button to v14.
dsolanki-initos Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pos_hide_banknote_button/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ Contributors
~~~~~~~~~~~~

* Sylvain LE GAL <https://twitter.com/legalsylvain>
* Dhara Solanki <[email protected]>

Maintainers
~~~~~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion pos_hide_banknote_button/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

{
"name": "Point of Sale - Hide Banknote Buttons",
"version": "12.0.1.0.0",
"version": "14.0.1.0.0",
"category": "Point Of Sale",
"summary": "Hide useless Banknote buttons in the PoS (+10, +20, +50)",
"author": "GRAP, Odoo Community Association (OCA)",
Expand Down
1 change: 1 addition & 0 deletions pos_hide_banknote_button/readme/CONTRIBUTORS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
* Sylvain LE GAL <https://twitter.com/legalsylvain>
* Dhara Solanki <[email protected]>
18 changes: 5 additions & 13 deletions pos_hide_banknote_button/static/src/css/pos_hide_banknote_button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,18 @@
License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
*/

.pos .payment-numpad .numpad button[data-action="+10"] {
visibility: hidden;
}

.pos .payment-numpad .numpad button[data-action="+20"] {
visibility: hidden;
}

.pos .payment-numpad .numpad button[data-action="+50"] {
.pos .payment-numpad .numpad button.mode-button {
visibility: hidden;
}

.pos .payment-numpad .numpad {
border-top: 0px solid;
}

.pos .payment-numpad .numpad button[data-action="1"],
.pos .payment-numpad .numpad button[data-action="2"],
.pos .payment-numpad .numpad button[data-action="3"],
.pos .payment-numpad .numpad button[data-action="BACKSPACE"] {
.pos .payment-numpad .numpad button:first-child,
.pos .payment-numpad .numpad button:nth-child(2),
.pos .payment-numpad .numpad button:nth-child(3),
.pos .payment-numpad .numpad button:last-child {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this new way is less predictive that the previous one. If other OCA modules are adding / altering numpad buttons, it could generate conflicts.

don't you think ?

Not sure how fix it thought.

Otherwise, lgtm, tested on runbot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but there is no other class which I can use to apply the css. If you have the otherway let me know about it.

border-top: 1px solid;
border-color: #cacaca;
}