[14.0] [mig] pos_cash_move_reason #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[REF] factor code [UPD] fr translation and pot file
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
[REF] Don't use ``product.product`` model for Reasons, because Odoo remove the fields ``expense_pdt`` ``and income_pdt`` from the model. Use instead a new model ``pos.move.reason`` for this purpose. [REF] Doesn't inherit from ``cash.box.in`` and ``cash.box.out`` model, as there are bad designed and doesn't allow clean inheritance. Instead, use new transient model ``wizard.pos.move.reason``. [REF] Oca convention. add readme folder.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/
Currently translated at 100.0% (38 of 38 strings) Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/
…e context timezone
Currently translated at 100.0% (38 of 38 strings) Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/fr_CH/
Currently translated at 7.9% (3 of 38 strings) Translation: pos-12.0/pos-12.0-pos_cash_move_reason Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/de/
dsolanki-initos
force-pushed
the
14.0-mig-pos_cash_move_reason
branch
from
3c7262a
to
2bdf291
Compare
|
Is it possible to get the review here? |
|
@dsolanki-initos Travis is failing, fix it before asking for reviews please |
|
Also, runbot is failing |
dsolanki-initos
force-pushed
the
14.0-mig-pos_cash_move_reason
branch
from
2bdf291
to
826416f
Compare
|
Hi @etobella |
|
now it works as expected, thanks, however, some tests would be great. |
fshah-initos
approved these changes
May 13, 2021
dsolanki-initos
force-pushed
the
14.0-mig-pos_cash_move_reason
branch
4 times, most recently
from
d7566fb
to
a665d9d
Compare
|
@chienandalu if would be great if you could merge the PR |
|
@legalsylvain It would be great if you add the reviews here |
|
It would be great if we cousl get the reviews here |
etobella
reviewed
Jun 10, 2021
| @@ -22,6 +23,10 @@ def setUpClass(cls): | |||
| )[0] | |||
| cls.deposit_reason = cls.env.ref("pos_cash_move_reason.bank_out_reason") | |||
|
|
|||
| def test_onchange_expense_reason(self): | |||
| self.deposit_reason._onchange_is_expense_reason() | |||
There was a problem hiding this comment.
The way to test onchanges is to use a Form
There was a problem hiding this comment.
Hi @etobella
I've updated the test for onchange using Form. You can review it.
dsolanki-initos
force-pushed
the
14.0-mig-pos_cash_move_reason
branch
from
a665d9d
to
a1d0bbb
Compare
|
It would be great if we get the reviews here |
ivantodorovich
approved these changes
Jul 20, 2021
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 53cc573. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.