[16.0][FIX] pos_stock_available_online: stock move updates #1250
Conversation
There was a problem hiding this comment.
@danielduqma Thank you for your contribution, please check out the small comments
| _name = "stock.notifier.pos.mixin" | ||
| _description = "Stock Notifier POS Mixin" | ||
|
|
||
| def _prepare_pos_message(self, warehouse=None): |
There was a problem hiding this comment.
The _prepare_pos_message is called directly in the warehouse loop in the _notify_pos method, which gets the list of warehouses using the _get_warehouses_to_notify method in this case warehouse will always be in the argument values, so it can be left as a mandatory argument.
def _prepare_pos_message(self, warehouse):
"""
Return prepared message to send to POS
"""
self.ensure_one()
return warehouse._prepare_vals_for_pos(self.product_id)There was a problem hiding this comment.
You're right, this was a first approach but the logic was moved to _get_warehouses_to_notify
|
|
||
| def _get_warehouses_to_notify(self): | ||
| self.ensure_one() | ||
| return self.warehouse_id |
There was a problem hiding this comment.
Since the current model is a mixin and can be plugged into any model this field may be missing which will cause an error, possible solution is to either return the model object return self.env["stock.warehouse"] or throw an exception raise NotImplementedError()
In the models where this mixin is connected, implement a method that returns the necessary warehouses
There was a problem hiding this comment.
This mixin was intended just to be inherited by stock.move and stock.quant, but I modified it as you proposed to be more extendable
|
LGTM |
Make stock updates not only on quant updates, but also when a stock move changes its state. This fixes two bugs: - Stock is not updated when a new incoming move is ready, or when a ready one is cancelled - Stock is decreased twice because when quant is updated, move is taken in account because it is not yet on 'done' state
danielduqma
force-pushed
the
16.0-fix-pos_stock_available_online
branch
from
47225e9
to
c9675a5
Compare
Make stock updates not only on quant updates, but also when a stock move changes its state.
This fixes two bugs:
Stock is not updated when a new incoming move is ready, or when a ready one is cancelled. This triggers notification in both outgoing and incoming warehouses
Stock is decreased twice because when quant is updated, move is taken in account because it is not yet on 'done' state. This was reported in After refund of 1 qty, POS qty display increased by 2 qty #1039, but the proposed solution in [16.0][FIX] pos_stock_available_online: FIX For After refund of 1 qty, POS qty display increased by 2 qty #1041 was local and only concerned moves from PoS orders
FL-556-4139