[16.0][FIX] pos_order_to_sale_order #1065

geomer198 · 2023-10-15T12:37:43Z

At creating SO from POS, description computed by default with adding customer note from POS.

OCA-git-bot · 2023-10-15T12:37:47Z

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

legalsylvain

Hi. Don't understand that PR.
I tested on runboat with the 16.0 module :

add a pos order line
add a comment
create a draft sale order

the comment is present in the name of the sale order line.

geomer198 · 2023-10-16T19:14:53Z

Hi. Don't understand that PR. I tested on runboat with the 16.0 module :
* add a pos order line

* add a comment

* create a draft sale order
the comment is present in the name of the sale order line.

In default module behavior product internal reference in sol is not displayed. Now products Internal reference is displayed.

legalsylvain · 2023-10-16T20:08:39Z

Thanks for the explanation !

Well, the problem IMO is that this PR introduce a useless field at sale.order.line level that will take space in the DB. We should consider another design.

I guess call _get_sale_order_line_multiline_description_sale in the prepare function should do the job. Don't you think ?

geomer198 · 2023-10-17T09:27:08Z

_get_sale_order_line_multiline_description_sale

Hello @legalsylvain ! This function (_get_sale_order_line_multiline_description_sale) is called after created SOL, so at preparing value I think better solution adding new field for saving customer_note.
For the applying _get_sale_order_line_multiline_description_sale function then need create so and sol without preparing value. I think this solution is not good(
What do you think about it?

legalsylvain · 2023-10-17T10:11:27Z

I think you can pass information by context. It could make the job.
but creating a useless field in database is an issue IMO.

ivs-cetmix · 2023-10-20T09:01:01Z

I think you can pass information by context. It could make the job. but creating a useless field in database is an issue IMO.

Hi @legalsylvain we have approached this problem from another angle) Could you have a look please?

legalsylvain · 2023-10-20T09:04:59Z

Hi. I'm on holidays the next week. I'll take a look when I'm back to the office.

ivs-cetmix · 2023-10-20T11:15:40Z

Hi. I'm on holidays the next week. I'll take a look when I'm back to the office.

Thank you! Have a nice holidays)

At creating SO from pos, description computed by default with adding customer note from POS.

ivs-cetmix · 2023-10-22T13:51:07Z

pos_order_to_sale_order/readme/CONFIGURE.rst

@@ -1,6 +1,7 @@
 * Go to Point Of Sale / Configuration / Point of Sale
 * Check the box 'Create Sale Orders'
 * Select the desired default behaviour
+* Select the SO Line Name mode


Select Sales Order Lina name composition mode

ivs-cetmix · 2023-10-22T13:52:55Z

pos_order_to_sale_order/readme/newsfragments/2928.bigfix.rst

@@ -0,0 +1 @@
+Sale order line description computed by default with adding Customer note.


This is not a bug. A feature is being added.
Add readable and clear feature description please

ivs-cetmix · 2023-10-22T13:54:47Z

pos_order_to_sale_order/models/res_config_settings.py

+            ("multiline", "Sale Multiline Description"),
+        ],
+        string="SO Line Name Mode",
+        default="product_pos",


What happens if user will remove selection value? So no option is selected

…efault value for config paramenter is changed.

ivs-cetmix · 2023-11-09T12:18:18Z

Hi. I'm on holidays the next week. I'll take a look when I'm back to the office.

Hi @legalsylvain sorry for bothering you again) Would be great if you could have a look at this

legalsylvain · 2023-11-09T14:01:36Z

pos_order_to_sale_order/models/sale_order_line.py

+            product_name = product.name
+            product_name += "\n" + order_line_data["customer_note"]
+            vals.update(name=product_name)
+        return vals


Maybe I'm wrong, but it looks like if the previous condition is wrong, the vals returned doesn't contain any "name" value. Did I missed something ?

Maybe I'm wrong, but it looks like if the previous condition is wrong, the vals returned doesn't contain any "name" value. Did I missed something ?

Thank you for you question!
Name field is auto complete after creating SOL. And this solution for the set custom value for SOL description.

legalsylvain · 2023-11-10T11:56:20Z

Hi @geomer198.

Hello @legalsylvain ! This function (_get_sale_order_line_multiline_description_sale) is called after created SOL, so at preparing value I think better solution adding new field for saving customer_note.

I don't think so. _get_sale_order_line_multiline_description_sale is called by the _compute_name function, before the call during the call of create.

I made an alternative implementation here #1080.

Thanks for you review.

geomer198 · 2023-11-15T13:41:59Z

Hi @geomer198.

Hello @legalsylvain ! This function (_get_sale_order_line_multiline_description_sale) is called after created SOL, so at preparing value I think better solution adding new field for saving customer_note.

I don't think so. _get_sale_order_line_multiline_description_sale is called by the _compute_name function, before the call during the call of create.

I made an alternative implementation here #1080.

Thanks for you review.

Thanks for your solution.
This solution looks better than my. I close my PR in favor of your implementation.

geomer198 marked this pull request as draft October 15, 2023 12:41

geomer198 marked this pull request as ready for review October 15, 2023 15:18

geomer198 force-pushed the 16.0-t2928-pos_order_to_sale_order-fix branch from af6760e to c5673c1 Compare October 15, 2023 15:18

legalsylvain requested changes Oct 15, 2023

View reviewed changes

[FIX] pos_order_to_sale_order: Sale order line create is changed.

0188833

At creating SO from pos, description computed by default with adding customer note from POS.

geomer198 force-pushed the 16.0-t2928-pos_order_to_sale_order-fix branch from a96796a to 0188833 Compare October 20, 2023 11:29

ivs-cetmix suggested changes Oct 22, 2023

View reviewed changes

[FIX] pos_order_to_sale_order: newsfragments is updated and setting d…

fc3ab80

…efault value for config paramenter is changed.

geomer198 force-pushed the 16.0-t2928-pos_order_to_sale_order-fix branch from c0f0d57 to fc3ab80 Compare October 22, 2023 18:11

legalsylvain reviewed Nov 9, 2023

View reviewed changes

legalsylvain mentioned this pull request Nov 10, 2023

[16.0][IMP] pos_order_to_sale_order : use customer note and correctly prepare sale.order.line name fields #1080

Merged

geomer198 closed this Nov 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][FIX] pos_order_to_sale_order #1065

[16.0][FIX] pos_order_to_sale_order #1065

geomer198 commented Oct 15, 2023

OCA-git-bot commented Oct 15, 2023

legalsylvain left a comment

geomer198 commented Oct 16, 2023

legalsylvain commented Oct 16, 2023

geomer198 commented Oct 17, 2023

legalsylvain commented Oct 17, 2023

ivs-cetmix commented Oct 20, 2023

legalsylvain commented Oct 20, 2023

ivs-cetmix commented Oct 20, 2023

ivs-cetmix Oct 22, 2023

ivs-cetmix Oct 22, 2023

ivs-cetmix Oct 22, 2023

ivs-cetmix commented Nov 9, 2023

legalsylvain Nov 9, 2023

geomer198 Nov 9, 2023

legalsylvain commented Nov 10, 2023

geomer198 commented Nov 15, 2023

		@@ -0,0 +1 @@
		Sale order line description computed by default with adding Customer note.

[16.0][FIX] pos_order_to_sale_order #1065

[16.0][FIX] pos_order_to_sale_order #1065

Conversation

geomer198 commented Oct 15, 2023

OCA-git-bot commented Oct 15, 2023

legalsylvain left a comment

Choose a reason for hiding this comment

geomer198 commented Oct 16, 2023

legalsylvain commented Oct 16, 2023

geomer198 commented Oct 17, 2023

legalsylvain commented Oct 17, 2023

ivs-cetmix commented Oct 20, 2023

legalsylvain commented Oct 20, 2023

ivs-cetmix commented Oct 20, 2023

ivs-cetmix Oct 22, 2023

Choose a reason for hiding this comment

ivs-cetmix Oct 22, 2023

Choose a reason for hiding this comment

ivs-cetmix Oct 22, 2023

Choose a reason for hiding this comment

ivs-cetmix commented Nov 9, 2023

legalsylvain Nov 9, 2023

Choose a reason for hiding this comment

geomer198 Nov 9, 2023

Choose a reason for hiding this comment

legalsylvain commented Nov 10, 2023

geomer198 commented Nov 15, 2023