Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][pos_customer_required_fields] if no customer required fields defined on pos config it's not possible to validate a pos order with customer #777

Closed
petrus-v opened this issue Apr 7, 2022 · 1 comment
Labels

Comments

@petrus-v
Copy link
Contributor

petrus-v commented Apr 7, 2022

Module

pos_customer_required_fields

Describe the bug

if no customer required fields defined on pos config it's not possible to validate a pos order with customer.

To Reproduce

Affected versions: 12.0

Steps to reproduce the behavior:

  1. ensure no customer required fields defined on pos config
  2. start pos session
  3. pick a customer and start payment screen
  4. try to validate payment

A popup with error message is displayed:

image

Expected behavior

payment should be validate without error

Additional context

technical explanation about this issue:

this.pos.config.res_partner_required_fields_names.split(",") return [""] one element which is not filtered because this.pos.config.res_partner_required_fields_names == "" in case there are no required fieds

@petrus-v petrus-v added the bug label Apr 7, 2022
petrus-v added a commit to petrus-v/pos that referenced this issue Apr 8, 2022
In case there is no required field we don't want to
lock user on payment screen.

As required fields list is stored in string variable
spliting an empty string return an array of one empty
string which would return one missing field which
is locking users
@petrus-v
Copy link
Contributor Author

I'm closing this issue as long #780 has been merged

hitrosol pushed a commit to solusiaglis/pos that referenced this issue Jun 4, 2022
In case there is no required field we don't want to
lock user on payment screen.

As required fields list is stored in string variable
spliting an empty string return an array of one empty
string which would return one missing field which
is locking users
LaetitiaElabore pushed a commit to elabore-coop/pos that referenced this issue Oct 1, 2024
In case there is no required field we don't want to
lock user on payment screen.

As required fields list is stored in string variable
spliting an empty string return an array of one empty
string which would return one missing field which
is locking users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant