-
-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] backport partner_bank_acc_type_constraint from 16 to 14 #1553
[14.0] backport partner_bank_acc_type_constraint from 16 to 14 #1553
Conversation
@alexis-via CI is 🔴 could you take a quick look? @legalsylvain @rousseldenis could you please make a quick review? |
@rafaelbn This module adds a constraint on res.partner.bank, so it blocks the demo data of some modules. I think we should exclude it from automated tests, unless if someone has a better idea. |
@rafaelbn Did you close the PR by mistake, or was it intentional ? |
By mistake @alexis-via ! Sorry! 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be sufficient to add this to the rebel modules?
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1553-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 8134a86. Thanks a lot for contributing to OCA. ❤️ |
Simple backport, no code change.