Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] backport partner_bank_acc_type_constraint from 16 to 14 #1553

Merged

Conversation

alexis-via
Copy link
Contributor

Simple backport, no code change.

@rafaelbn rafaelbn modified the milestones: 13.0, 10.0, 14.0 Aug 11, 2023
@rafaelbn
Copy link
Member

@alexis-via CI is 🔴 could you take a quick look?

@legalsylvain @rousseldenis could you please make a quick review?

@alexis-via
Copy link
Contributor Author

@rafaelbn This module adds a constraint on res.partner.bank, so it blocks the demo data of some modules. I think we should exclude it from automated tests, unless if someone has a better idea.

@alexis-via
Copy link
Contributor Author

@rafaelbn Did you close the PR by mistake, or was it intentional ?

@rafaelbn rafaelbn reopened this Aug 11, 2023
@rafaelbn
Copy link
Member

By mistake @alexis-via ! Sorry! 🙏🏼

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be sufficient to add this to the rebel modules?

@dreispt
Copy link
Member

dreispt commented Dec 28, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1553-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 28, 2023
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1553-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Member

dreispt commented Feb 22, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1553-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit af64364 into OCA:14.0 Feb 22, 2024
6 of 10 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8134a86. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants