Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] convert_field_to_html: fix format call on string #387

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[FIX] convert_field_to_html: fix format call on string #387

merged 1 commit into from
Oct 10, 2024

Conversation

GuillemCForgeFlow
Copy link
Contributor

No description provided.

@MiquelRForgeFlow MiquelRForgeFlow merged commit ba6ec53 into OCA:master Oct 10, 2024
2 checks passed
@MiquelRForgeFlow MiquelRForgeFlow deleted the fix-convert_field_to_html branch October 10, 2024 13:50
@pedrobaeza
Copy link
Member

I don't get the fix... and this should be done using sql.SQL and sql.Identifier for proper SQL wrapping.

@MiquelRForgeFlow
Copy link
Contributor

I don't get the fix

.format was being called outside of the cr.execute()

@pedrobaeza
Copy link
Member

Ah, OK, didn't see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillemCForgeFlow @pedrobaeza @MiquelRForgeFlow