[ADD] tree to list script #94
Conversation
lef-adhoc
force-pushed
the
17.0-t-43568-lef
branch
5 times, most recently
from
de30f5d to
36e440d
Compare
| @@ -0,0 +1,53 @@ | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | |||
There was a problem hiding this comment.
this file looks a copy past of this Odoo/odoo file https://github.com/odoo/odoo/blob/master/odoo/upgrade_code/17.5-00-tree-to-list.py
- copyright and author should be conserved.
- you have not right to change the licence of the code. (the current code is LGPL, not AGPL)
what do you think ?
There was a problem hiding this comment.
About the licence, I'm not sure, but I think that should be ok if we remove that line and mention the author in a comment with a link to the original code.
There was a problem hiding this comment.
Well. Regarding the licence of this part of code, there is no choice. This code is LGPL. Except if odoo allow you to change licence, you have to mention that licence in that file.
There was a problem hiding this comment.
@legalsylvain I’ve updated the file as per your suggestions:
Restored the license to LGPL-3.0.
Added a comment attributing the original method replace_tree_with_list_in_views from the source: Odoo 17.5-00-tree-to-list.py.
Please let me know if this looks good to you.
|
Technical review LGTM |
lef-adhoc
force-pushed
the
17.0-t-43568-lef
branch
from
36e440d to
84e681a
Compare
|
What a great day to merge this nice PR. Let's do it! |
Signed-off-by legalsylvain
|
Hi, @legalsylvain |
|
I don't know. /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
Signed-off-by legalsylvain
|
Hi @pedrobaeza |
|
There's no CI associated with merging branches, so there's no reaction either. This project is not prepared for ocabot. Just merging manually. |
thanks. I didn't know. |
More info here: odoo/odoo#159909
Odoo script: https://github.com/odoo/odoo/blob/master/odoo/upgrade_code/17.5-00-tree-to-list.py