-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: Odoo <14.0: pin black click dependency to <8.1.0 - Odoo >=14.0: bump black to 22.3.0 #134
Conversation
…bump black to 22.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-commit is failing due to the issue that this PR is trying to solve. I think we can excepcionally ignore the pre-commit failure
Now is green :) |
@sbidoul can you merge and release a version for solving the problem across OCA? |
Thanks! I tagged and released. |
Example here: OCA/mis-builder#426 |
Thanks. Are we going to apply it massively? |
I can do that later this week when we've got some feedback on the release. |
OK, we have to take into account that all CIs will be red for 14.0 and 15.0 meanwhile. I will update some repos applying manually the template. |
I'm deploying to all repos, 13, 14, 15. At first sight there are some pylint failures due to |
In the meantime, click 8.1.1 is out, which resolves the issue 🤷♂️ |
@sbidoul v8.1.1 gives the same problem as far as I have checked. https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-1 |
trying OCA/server-auth#365 |
My mass update script crashed at the letter |
Fix #133