Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: Odoo <14.0: pin black click dependency to <8.1.0 - Odoo >=14.0: bump black to 22.3.0 #134

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Mar 29, 2022

Fix #133

  • <14.0: pin black click dependency
  • >=14.0: bump black to 22.3.0

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-commit is failing due to the issue that this PR is trying to solve. I think we can excepcionally ignore the pre-commit failure

@Tardo
Copy link
Member Author

Tardo commented Mar 29, 2022

Now is green :)

@pedrobaeza
Copy link
Member

@sbidoul can you merge and release a version for solving the problem across OCA?

@sbidoul sbidoul merged commit 382f30f into OCA:master Mar 29, 2022
@sbidoul
Copy link
Member

sbidoul commented Mar 29, 2022

Thanks! I tagged and released.

@sbidoul
Copy link
Member

sbidoul commented Mar 29, 2022

Example here: OCA/mis-builder#426
Some noise due to black removing python 2 unicode string prefixes.

@pedrobaeza pedrobaeza deleted the fix-precommit-bump_black branch March 29, 2022 18:03
@pedrobaeza
Copy link
Member

Thanks. Are we going to apply it massively?

@sbidoul
Copy link
Member

sbidoul commented Mar 29, 2022

Thanks. Are we going to apply it massively?

I can do that later this week when we've got some feedback on the release.

@pedrobaeza
Copy link
Member

OK, we have to take into account that all CIs will be red for 14.0 and 15.0 meanwhile. I will update some repos applying manually the template.

@sbidoul
Copy link
Member

sbidoul commented Mar 30, 2022

I'm deploying to all repos, 13, 14, 15.

At first sight there are some pylint failures due to [W7940(dangerous-view-replace-wo-priority), ] Dangerous use of "replace" from view with priority 0 < 99. I'm not sure when this check became mandatory.

@sbidoul
Copy link
Member

sbidoul commented Mar 31, 2022

In the meantime, click 8.1.1 is out, which resolves the issue 🤷‍♂️

@Tardo
Copy link
Member Author

Tardo commented Mar 31, 2022

@sbidoul v8.1.1 gives the same problem as far as I have checked.

https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-1

@gurneyalex
Copy link
Member

trying OCA/server-auth#365

@sbidoul
Copy link
Member

sbidoul commented Mar 31, 2022

My mass update script crashed at the letter o. It's been restarted now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit: Black < 22.3.0 is incompatible with click 8.1.0
6 participants