Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] calendar_event_type_multi_company: Migration to 16.0 #681

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] calendar_event_type_multi_company: Migration to 16.0 #681

wants to merge 2 commits into from

Conversation

TelmoSuarez
Copy link

No description provided.

amh-mw
amh-mw approved these changes Aug 14, 2024
View reviewed changes
Copy link

@amh-mw amh-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would squash the "pre-commit stuff" commit into the MIG commit, and also retitle the original commit to something like "[ADD] calendar_event_type_multi_company:" but otherwise LGTM.

@TelmoSuarez TelmoSuarez force-pushed the 16.0-mig-calendar_event_type_multi_company branch from 888b077 to 42bc614 Compare August 19, 2024 06:32
@TelmoSuarez
Copy link
Author

@amh-mw Ty for the review!
Commits squashed and retitled original commit.

Christian-RB
Christian-RB approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amh-mw amh-mw amh-mw approved these changes

@Christian-RB Christian-RB Christian-RB approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TelmoSuarez @OCA-git-bot @amh-mw @Christian-RB @sbejaoui