Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] mrp_bom_structure_xlsx: Migration to 12.0 #56

Merged
merged 11 commits into from
May 28, 2019
Merged

[12.0][MIG] mrp_bom_structure_xlsx: Migration to 12.0 #56

merged 11 commits into from
May 28, 2019

Conversation

bodedra
Copy link
Member

@bodedra bodedra commented May 27, 2019

No description provided.

@oca-clabot
Copy link

Hey @bodedra, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

tbaden
tbaden suggested changes May 27, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: LGTM, just a minor detail:

mrp_bom_structure_xlsx/readme/CREDITS.rst Outdated Show resolved Hide resolved
@bodedra bodedra force-pushed the 12.0-mig-mrp_bom_structure_xlsx branch from b5cb69a to ff6aa8d Compare May 28, 2019 05:23
@bodedra
Copy link
Member Author

bodedra commented May 28, 2019

@tbaden Attended comment! Thanks for your review.

@bodedra
Copy link
Member Author

bodedra commented May 28, 2019

@jbeficent @mreficent @lreficent @aheficent

AaronHForgeFlow
AaronHForgeFlow approved these changes May 28, 2019
View reviewed changes
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test on runbot LGTM

MiquelRForgeFlow
MiquelRForgeFlow approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiquelRForgeFlow
Copy link
Contributor

please drop "DROP THIS! oca_dependency update" commit

@bodedra bodedra force-pushed the 12.0-mig-mrp_bom_structure_xlsx branch from ff6aa8d to 813d13a Compare May 28, 2019 07:46
@bodedra
Copy link
Member Author

bodedra commented May 28, 2019

@aheficent @mreficent Comment Attended! Thanks for your review.

HaraldPanten
HaraldPanten approved these changes May 28, 2019
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@bodedra bodedra mentioned this pull request May 28, 2019
Open
8 tasks
@bodedra
Copy link
Member Author

bodedra commented May 28, 2019

@OCA/manufacturing-maintainers can we merge these. 😉

@pedrobaeza pedrobaeza merged commit 5ecbabb into OCA:12.0 May 28, 2019
@bodedra bodedra deleted the 12.0-mig-mrp_bom_structure_xlsx branch May 28, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@tbaden tbaden tbaden approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.