Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] mrp_flattened_bom_xlsx: Create print button at installing module #105

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

BernatPForgeFlow
Copy link
Member

PR related to this issue: #104

Copy link

@kluna1998 kluna1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and functional review 👍🏽

@LoisRForgeFlow LoisRForgeFlow force-pushed the 14.0-fix-mrp_flattened_bom_xlsx branch from 3741c6d to 29611ef Compare April 20, 2023 10:59
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-105-by-LoisRForgeFlow-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 20, 2023
Signed-off-by LoisRForgeFlow
@OCA-git-bot
Copy link
Contributor

@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-105-by-LoisRForgeFlow-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-105-by-LoisRForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 845bf30 into OCA:14.0 Apr 20, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2040920. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 14.0-fix-mrp_flattened_bom_xlsx branch April 20, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants