This repository has been archived by the owner on May 16, 2024. It is now read-only.
Remove coverall suport, install codecov in travis_after_test_success #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should remove all the coveralls remnants instead. We are using codecov since a lot. |
sbidoul
force-pushed
the
coverage-sbi
branch
3 times, most recently
from
ad0cfb8 to
f941d00
Compare
sbidoul
changed the title
max3903
approved these changes
Mar 21, 2020
sbidoul
force-pushed
the
coverage-sbi
branch
2 times, most recently
from
384ded8 to
a26ddf7
Compare
|
still WIP |
Also, install codecov only when needed to avoid having uneeded and possibly conflicting dependencies during tests
sbidoul
commented
Mar 21, 2020
| - LINT_CHECK="1" travis_install_nightly 8.0 # only used if VERSION not set in env | ||
| - git --git-dir=${TRAVIS_BUILD_DIR}/.git add --all # All modules moved are modules changed to test PR changes | ||
|
|
||
| script: | ||
| - TRAVIS_PULL_REQUEST="1" coverage run --append ./travis/travis_run_tests 8.0 # only used if VERSION not set in env | ||
| - TRAVIS_PULL_REQUEST="1" coverage run ./travis/travis_run_tests 8.0 # only used if VERSION not set in env |
There was a problem hiding this comment.
I think the root cause was this.
|
Ok, this works. Good to go. |
|
Thanks for fixing @sbidoul 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended by https://docs.coveralls.io/python
fixes #642