Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] delivery_dhl_parcel: Migration to 17.0 #3658

Open
wants to merge 23 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] delivery_dhl_parcel: Migration to 17.0 #3658

wants to merge 23 commits into from

Conversation

arantxa-s73
Copy link

@arantxa-s73 arantxa-s73 commented Jul 3, 2024 •
edited
Loading

Standard migration delivery_dhl_parcel

Depends on:

@pedrobaeza
Copy link
Member

Arantxa, evita por favor cerrar el PR cada vez que quieres hacer un cambio. Puedes simplemente empujar en la misma rama con git push -f para sobrescribir lo que haya. El título del PR tampoco es correcto. Cámbialo por favor.

@arantxa-s73 arantxa-s73 force-pushed the 17.0-mig-delivery_dhl_parcel branch from ff23e1f to 8bd0132 Compare July 5, 2024 10:49
@arantxa-s73 arantxa-s73 changed the title 17.0 mig delivery dhl parcel [17.0][MIG] delivery_dhl_parcel: Migration to 17.0 Jul 5, 2024
@hildickethan
Copy link
Member

hildickethan commented Jul 9, 2024 •
edited
Loading

Haz cherry-pick de #3659 también, el módulo a nivel funcional es OK

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 8, 2024
@ioans73
Copy link
Member

ioans73 commented Dec 9, 2024

@pedrobaeza Could you add "no stale" label please?

@pedrobaeza
Copy link
Member

Haced rebase quitando el commit de dependencia, ya que ahora está todo fusionado.

hildickethan and others added 20 commits December 9, 2024 08:09
@hildickethan @ioans73
[14.0][ADD] delivery_dhl_parcel: DHL Parcel integration with Odoo
6c8de7d 
[UPD] Update delivery_dhl_parcel.pot

[UPD] README.rst
@ioans73
[IMP] delivery_dhl_parcel: Producto DHL (B2B/B2C/R2C)
f0db4bf 
delivery_dhl_parcel 14.0.1.1.0

[UPD] Update delivery_dhl_parcel.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/
@victoralmau @ioans73
[IMP] delivery_dhl_parcel: Remove dhl_parcel_last_request + dhl_parce…
019fa6e 
…l_last_response fields.

[UPD] Update delivery_dhl_parcel.pot

[UPD] README.rst

delivery_dhl_parcel 14.0.1.2.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/
@hildickethan @ioans73
[FIX] delivery_dhl_parcel: Fix log_xml
e8f830c 
log_xml is a carrier function, self in this context is the DhlParcelRequest class

delivery_dhl_parcel 14.0.1.2.1
@extrememicro @ioans73
Added translation using Weblate (Catalan)
c472738
@extrememicro @ioans73
Translated using Weblate (Catalan)
4f641cb 
Currently translated at 2.1% (1 of 46 strings)

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/ca/
@hildickethan @ioans73
[14.0][IMP] delivery_dhl_parcel: Minimum 1 kg en envíos DHL
fc014b6 
400 Client Error: Bad Request for url: https://external.dhl.es/cimapi/api/v1/customer/shipment
El peso del envío tiene que ser como mínimo 1 kilo o como máximo 99999 kilos

delivery_dhl_parcel 14.0.1.2.2
@victoralmau @ioans73
[IMP] delivery_dhl_parcel: Add the label format on the carrier.
a914c52 
TT37163

[UPD] Update delivery_dhl_parcel.pot

[UPD] README.rst

delivery_dhl_parcel 14.0.1.3.0
@victoralmau @ioans73
[IMP] delivery_dhl_parcel: Add all customer accounts check option to …
13aead3 
…end day wizard.

TT37046

[UPD] Update delivery_dhl_parcel.pot

delivery_dhl_parcel 14.0.1.4.0
@victoralmau @ioans73
[FIX] delivery_dhl_parcel: Round the weight of the shipment to avoid …
244edac 
…errors at the end of the day.

TT37136

delivery_dhl_parcel 14.0.1.4.1
@victoralmau @ioans73
[FIX] delivery_dhl_parcel: Save the file in the correct extension in …
f7007f9 
…all use cases.

TT37136
@victoralmau @ioans73
[FIX] delivery_dhl_parcel: Set the correct label format when creating…
8008cd8 
… the shipment.

TT37461

delivery_dhl_parcel 14.0.1.4.2

delivery_dhl_parcel 14.0.1.4.3
@hildickethan @ioans73
[IMP] delivery_dhl_parcel: Add maintainer
c93362d 
[UPD] README.rst

delivery_dhl_parcel 14.0.1.4.4
@victoralmau @ioans73
[IMP] delivery_dhl_parcel: Update documentation
fda6458 
TT40002
@victoralmau @ioans73
[FIX] delivery_dhl_parcel: Improve changes
4171ee4 
Create _prepare_dhl_parcel_parcel_address_info() function to reduce code.

Improve receiver + sender information:
- Remove blank spaces on partner phone
- Set phone or mobile from partner
- Concatenate street and street2 field
- Limit address field to 40 characters

TT40002

delivery_dhl_parcel 14.0.1.4.5
@hildickethan @ioans73
[IMP] delivery_dhl_parcel: Cash on delivery
64f02d3 
[UPD] Update delivery_dhl_parcel.pot

[UPD] README.rst

delivery_dhl_parcel 14.0.2.0.0

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/
@Ivorra78 @ioans73
Translated using Weblate (Spanish)
bcf865d 
Currently translated at 100.0% (54 of 54 strings)

Translation: l10n-spain-14.0/l10n-spain-14.0-delivery_dhl_parcel
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-delivery_dhl_parcel/es/
@victoralmau @ioans73
[MIG] delivery_dhl_parcel: Migration to 15.0
5c7a53a 
TT48078
@ioans73
[UPD] Update delivery_dhl_parcel.pot
c8bf42a
@arantxa-s73 @ioans73
[IMP] delivery_dhl_parcel: pre-commit auto fixes
a57ccc3
@ioans73 ioans73 force-pushed the 17.0-mig-delivery_dhl_parcel branch from 367be81 to e0f1756 Compare December 9, 2024 07:09
@ioans73
Copy link
Member

ioans73 commented Dec 9, 2024

Haced rebase quitando el commit de dependencia, ya que ahora está todo fusionado.

Hecho!

pedrobaeza
pedrobaeza reviewed Dec 9, 2024
View reviewed changes
delivery_dhl_parcel/models/delivery_carrier.py
@@ -169,6 +169,7 @@ def dhl_parcel_send_shipping(self, pickings):
result.append(vals)
continue
vals["tracking_number"] = response.get("Tracking", "")
vals["response"] = response
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esta nueva línea para qué es? No veo ningún campo con ese nombre.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es por este pr de la versión 14, #3508

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eso no se ha aprobado, y además, no se almacena en ningún sitio según veo. Quítalo por favor.

arantxa-s73 and others added 2 commits December 10, 2024 08:13
@arantxa-s73
[MIG] delivery_dhl_parcel: Migration to 17.0
fb1bad1
@chienandalu @arantxa-s73
[FIX] delivery_dhl_parcel: show full name
c3a4cb3 
If we just show the partner's name there will be cases where we'll be
losing the most important info which is the main organization where the
shipping is sent.

TT49966
@arantxa-s73 arantxa-s73 force-pushed the 17.0-mig-delivery_dhl_parcel branch from e0f1756 to c3a4cb3 Compare December 10, 2024 07:14
@david-s73
[IMP] delivery_dhl_parcel: refactor dhl_parcel_send_shipping
e681537 
The response is added in the field response because the response field contains the tracking number so that value is lost if it is not added to vals.
@david-s73
Copy link
Contributor

david-s73 commented Dec 13, 2024 •
edited
Loading

@pedrobaeza Tengo que añadir el response en el campo vals ya que sino se pierde el numero de seguimiento del dhl así que no se rellena en ningún otro sitio ya que por eso se tiene que pasar el reponse al vals

@david-s73 david-s73 mentioned this pull request Dec 13, 2024
Closed
@pedrobaeza
Copy link
Member

Pero insisto en que no existe ningún campo response declarado en ningún modelo:

imagen

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 15, 2024
@david-s73
Copy link
Contributor

@pedrobaeza Así es no existe ningún campo que se llame response pero a lo que me refiero es que cuando la función dhl_parcel_send_shipping devuelve result necesito que este contenga el response. Ya que cuando hace el result.append(vals) si ha vals no se le pasas el response entonces se pierde.

@pedrobaeza
Copy link
Member

Claro, pero no se puede pasar un campo que no existe o dará error, y en ningún sitio del campo luego se quita ese valor del diccionario. Si quieres coger algún otro valor, extráelo adecuamente y lo colocas en un campo que exista.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@arantxa-s73 @pedrobaeza @hildickethan @ioans73 @david-s73 @victoralmau @extrememicro @Ivorra78 @chienandalu