[8.0][IMP][payment_redsys] Don't die on missing dependencies #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| from Crypto.Cipher import DES3 | ||
| except ImportError: | ||
| _logger.info("Missing dependency. See README.") |
There was a problem hiding this comment.
Please put what is the missing dependency
There was a problem hiding this comment.
Yeah, but someone seeing the log doesn't see the README
|
@sergio-incaser, please take care with this kind of things. |
|
Yes, having error 500 in updates is not funny 😕 |
|
👍 fast-tracking when Travis finishes |
pedrobaeza
added a commit
that referenced
this pull request
Nov 23, 2015
[8.0][IMP][payment_redsys] Don't die on missing dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency documented, and ImportError handled. Now you are required to have the dependency only to install and use this module, but if you do not want it, your whole system will not die with error 500.
CC @sergio-incaser @pedrobaeza.